Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: Source/core/style/ComputedStyle.h

Issue 1251523003: Delete AuthorStyleInfo and move its data into ComputedStyle.RareNonInheritedData. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove spurious comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1546 matching lines...) Expand 10 before | Expand all | Expand 10 after
1557 bool hasExplicitlyInheritedProperties() const { return noninherited_flags.ex plicitInheritance; } 1557 bool hasExplicitlyInheritedProperties() const { return noninherited_flags.ex plicitInheritance; }
1558 1558
1559 bool hasChildDependentFlags() const { return emptyState() || hasExplicitlyIn heritedProperties(); } 1559 bool hasChildDependentFlags() const { return emptyState() || hasExplicitlyIn heritedProperties(); }
1560 void copyChildDependentFlagsFrom(const ComputedStyle&); 1560 void copyChildDependentFlagsFrom(const ComputedStyle&);
1561 1561
1562 bool hasBoxDecorations() const { return hasBorderDecoration() || hasBorderRa dius() || hasOutline() || hasAppearance() || boxShadow() || hasFilter() || resiz e() != RESIZE_NONE; } 1562 bool hasBoxDecorations() const { return hasBorderDecoration() || hasBorderRa dius() || hasOutline() || hasAppearance() || boxShadow() || hasFilter() || resiz e() != RESIZE_NONE; }
1563 1563
1564 bool borderObscuresBackground() const; 1564 bool borderObscuresBackground() const;
1565 void getBorderEdgeInfo(BorderEdge edges[], bool includeLogicalLeftEdge = tru e, bool includeLogicalRightEdge = true) const; 1565 void getBorderEdgeInfo(BorderEdge edges[], bool includeLogicalLeftEdge = tru e, bool includeLogicalRightEdge = true) const;
1566 1566
1567 void setHasAuthorBackground(bool authorBg) { SET_VAR(rareNonInheritedData, m _hasAuthorBackground, authorBg ? 1 : 0); }
Timothy Loh 2015/07/29 03:37:08 No need to abbreviate background. Also does the te
meade_UTC10 2015/07/30 05:38:18 SET_VAR seems to do bitwise operations, and I didn
1568 void setHasAuthorBorder(bool authorBorder) { SET_VAR(rareNonInheritedData, m _hasAuthorBorder, authorBorder ? 1 : 0); }
1569 bool hasAuthorBackground() const { return rareNonInheritedData->m_hasAuthorB ackground; };
1570 bool hasAuthorBorder() const { return rareNonInheritedData->m_hasAuthorBorde r; };
1571
1567 // Initial values for all the properties 1572 // Initial values for all the properties
1568 static EBorderCollapse initialBorderCollapse() { return BSEPARATE; } 1573 static EBorderCollapse initialBorderCollapse() { return BSEPARATE; }
1569 static EBorderStyle initialBorderStyle() { return BNONE; } 1574 static EBorderStyle initialBorderStyle() { return BNONE; }
1570 static OutlineIsAuto initialOutlineStyleIsAuto() { return AUTO_OFF; } 1575 static OutlineIsAuto initialOutlineStyleIsAuto() { return AUTO_OFF; }
1571 static NinePieceImage initialNinePieceImage() { return NinePieceImage(); } 1576 static NinePieceImage initialNinePieceImage() { return NinePieceImage(); }
1572 static LengthSize initialBorderRadius() { return LengthSize(Length(0, Fixed) , Length(0, Fixed)); } 1577 static LengthSize initialBorderRadius() { return LengthSize(Length(0, Fixed) , Length(0, Fixed)); }
1573 static ECaptionSide initialCaptionSide() { return CAPTOP; } 1578 static ECaptionSide initialCaptionSide() { return CAPTOP; }
1574 static EClear initialClear() { return CNONE; } 1579 static EClear initialClear() { return CNONE; }
1575 static LengthBox initialClip() { return LengthBox(); } 1580 static LengthBox initialClip() { return LengthBox(); }
1576 static TextDirection initialDirection() { return LTR; } 1581 static TextDirection initialDirection() { return LTR; }
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
1941 } 1946 }
1942 1947
1943 inline bool ComputedStyle::hasPseudoElementStyle() const 1948 inline bool ComputedStyle::hasPseudoElementStyle() const
1944 { 1949 {
1945 return noninherited_flags.pseudoBits & PSEUDO_ELEMENT_MASK; 1950 return noninherited_flags.pseudoBits & PSEUDO_ELEMENT_MASK;
1946 } 1951 }
1947 1952
1948 } // namespace blink 1953 } // namespace blink
1949 1954
1950 #endif // ComputedStyle_h 1955 #endif // ComputedStyle_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698