Delete AuthorStyleInfo and move its data into ComputedStyle.RareNonInheritedData.

Source/core/css/resolver/StyleResolver.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 460 matching lines @@
     // Document::inheritHtmlAndBodyElementStyles.
     documentStyle->setDisplay(BLOCK);
     documentStyle->setScrollBlocksOn(WebScrollBlocksOnStartTouch | WebScrollBlocksOnWheelEvent);
     documentStyle->setPosition(AbsolutePosition);
 
     document.setupFontBuilder(*documentStyle);
 
     return documentStyle.release();
 }
 
-AuthorStyleInfo StyleResolver::authorStyleInfo(StyleResolverState& state)
-{
-    const CachedUAStyle* cachedUAStyle = state.cachedUAStyle();
-
-    if (!cachedUAStyle)
-        return AuthorStyleInfo();
-
-    // Exclude background-repeat from comparison by resetting it.
-    FillLayer backgroundCopy = cachedUAStyle->backgroundLayers;
-    FillLayer backgroundLayersCopy = state.style()->backgroundLayers();
-    backgroundCopy.setRepeatX(NoRepeatFill);
-    backgroundCopy.setRepeatY(NoRepeatFill);
-    backgroundLayersCopy.setRepeatX(NoRepeatFill);
-    backgroundLayersCopy.setRepeatY(NoRepeatFill);
-
-    bool backgroundChanged = backgroundLayersCopy != backgroundCopy
-        || state.style()->backgroundColor() != cachedUAStyle->backgroundColor;
-    bool borderChanged = state.style()->border() != cachedUAStyle->border;
-
-    return AuthorStyleInfo(backgroundChanged, borderChanged);
-}
-
 void StyleResolver::adjustComputedStyle(StyleResolverState& state, Element* element)
 {
     StyleAdjuster adjuster(document().inQuirksMode());
-    adjuster.adjustComputedStyle(state.mutableStyleRef(), *state.parentStyle(), element, authorStyleInfo(state));
+    adjuster.adjustComputedStyle(state.mutableStyleRef(), *state.parentStyle(), element);
 }
 
 // Start loading resources referenced by this style.
 void StyleResolver::loadPendingResources(StyleResolverState& state)
 {
     m_styleResourceLoader.loadPendingResources(state.style(), state.elementStyleResources());
     document().styleEngine().fontSelector()->fontLoader()->loadPendingFonts();
 }
 
 PassRefPtr<ComputedStyle> StyleResolver::styleForElement(Element* element, const ComputedStyle* defaultParent, StyleSharingBehavior sharingBehavior,
@@ skipping 811 matching lines @@
     // If our font got dirtied, go ahead and update it now.
     updateFont(state);
 
     // Many properties depend on the font. If it changes we just apply all properties.
     if (cachedMatchedProperties && cachedMatchedProperties->computedStyle->fontDescription() != state.style()->fontDescription())
         applyInheritedOnly = false;
 
     // Now do the normal priority UA properties.
     applyMatchedProperties<LowPropertyPriority>(state, matchResult, false, matchResult.beginUA(), matchResult.endUA(), applyInheritedOnly);
 
-    // Cache the UA properties to pass them to LayoutTheme in adjustComputedStyle.
-    state.cacheUserAgentBorderAndBackground();
+    // Make a copy of the current UA border and background so we can compare after matching other properties.

[Timothy Loh, 2015/07/29 03:37:07]

Can we just keep using CachedUAStyle and only create it if appearance is set at
this point?

[meade_UTC10, 2015/07/30 05:38:17]

Done.

+    FillLayer uaBgFill = state.style()->backgroundLayers();
+    StyleColor uaBgColor = state.style()->backgroundColor();
+    BorderData uaBorder = state.style()->border();
 
     // Now do the author and user normal priority properties and all the !important properties.
     applyMatchedProperties<LowPropertyPriority>(state, matchResult, false, matchResult.beginAuthor(), matchResult.endAuthor(), applyInheritedOnly);
     applyMatchedProperties<LowPropertyPriority>(state, matchResult, true, matchResult.beginAuthor(), matchResult.endAuthor(), applyInheritedOnly);
     applyMatchedProperties<LowPropertyPriority>(state, matchResult, true, matchResult.beginUA(), matchResult.endUA(), applyInheritedOnly);
 
+    // Compare the saved UA bg and border.
+    state.style()->setHasAuthorBackground(backgroundChanged(uaBgFill, uaBgColor, state));
+    state.style()->setHasAuthorBorder(uaBorder != state.style()->border());
+
     loadPendingResources(state);
 
     if (!cachedMatchedProperties && cacheHash && MatchedPropertiesCache::isCacheable(element, *state.style(), *state.parentStyle())) {
         INCREMENT_STYLE_STATS_COUNTER(*this, matchedPropertyCacheAdded, 1);
         m_matchedPropertiesCache.add(*state.style(), *state.parentStyle(), cacheHash, matchResult);
     }
 
     ASSERT(!state.fontBuilder().fontDirty());
 }
 
+bool StyleResolver::backgroundChanged(const FillLayer& oldLayer, const StyleColor& oldColor, const StyleResolverState& state)
+{
+    FillLayer oldFill = oldLayer;
+    FillLayer newFill = state.style()->backgroundLayers();
+    // Exclude background-repeat from comparison by resetting it.
+    oldFill.setRepeatX(NoRepeatFill);
+    oldFill.setRepeatY(NoRepeatFill);
+    newFill.setRepeatX(NoRepeatFill);
+    newFill.setRepeatY(NoRepeatFill);
+
+    return (oldFill != newFill || oldColor != state.style()->backgroundColor());
+}
+
 void StyleResolver::applyCallbackSelectors(StyleResolverState& state)
 {
     if (!m_watchedSelectorsRules)
         return;
 
     ElementRuleCollector collector(state.elementContext(), m_selectorFilter, state.style());
     collector.setMode(SelectorChecker::CollectingStyleRules);
 
     MatchRequest matchRequest(m_watchedSelectorsRules.get(), true);
     collector.collectMatchingRules(matchRequest);
@@ skipping 70 matching lines @@
     visitor->trace(m_watchedSelectorsRules);
     visitor->trace(m_treeBoundaryCrossingRules);
     visitor->trace(m_styleResourceLoader);
     visitor->trace(m_styleSharingLists);
     visitor->trace(m_pendingStyleSheets);
     visitor->trace(m_document);
 #endif
 }
 
 } // namespace blink