Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 125151: Add a switch for changing the fd limit on Mac/Linux.... (Closed)

Created:
11 years, 6 months ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Add a switch for changing the fd limit on Mac/Linux. Bump up the default fd limit on the Mac; stopgap fix for page cyclers, but something we want long-term to improve performance once we handle fd exhaustion with delays. BUG=none TEST=Launching with --file-descriptor-limit=20 should crash the renderer almost immediately. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18446

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M chrome/browser/browser_main.cc View 1 2 3 chunks +38 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
stuartmorgan
11 years, 6 months ago (2009-06-15 21:26:53 UTC) #1
TVL
lgtm http://codereview.chromium.org/125151/diff/1/2 File chrome/browser/browser_main.cc (right): http://codereview.chromium.org/125151/diff/1/2#newcode211 Line 211: setrlimit(RLIMIT_NOFILE, &limits); check return result and LOG(ERROR)/LOG(INFO) ...
11 years, 6 months ago (2009-06-15 21:39:18 UTC) #2
stuartmorgan
11 years, 6 months ago (2009-06-15 21:49:25 UTC) #3
http://codereview.chromium.org/125151/diff/1/2
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/125151/diff/1/2#newcode211
Line 211: setrlimit(RLIMIT_NOFILE, &limits);
On 2009/06/15 21:39:18, TVL wrote:
> check return result and LOG(ERROR)/LOG(INFO) if it fails?

Done.

http://codereview.chromium.org/125151/diff/1/2#newcode212
Line 212: }
On 2009/06/15 21:39:18, TVL wrote:
> log if get failed?

Done.

http://codereview.chromium.org/125151/diff/1001/7
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/125151/diff/1001/7#newcode510
Line 510: const wchar_t kFileDescriptorLimit[]                =
L"file-descriptor-limit";
On 2009/06/15 21:39:18, TVL wrote:
> align = with the otehrs (last few don't seem to align...

Done (again; helps when I change the variable name *then* align, rather than the
reverse).

Powered by Google App Engine
This is Rietveld 408576698