Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1251493003: Clearer error message if pyelftools is not installed (Closed)

Created:
5 years, 5 months ago by kulakowski
Modified:
5 years, 5 months ago
Reviewers:
jamesr, ppi
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Clearer error message if pyelftools is not installed R=ppi@google.com

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/devtools/common/android_gdb/session.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (2 generated)
kulakowski
5 years, 5 months ago (2015-07-21 18:32:27 UTC) #1
ppi
lgtm
5 years, 5 months ago (2015-07-22 18:06:42 UTC) #3
kulakowski
On 2015/07/22 18:06:42, ppi wrote: > lgtm I don't seem to have push access to ...
5 years, 5 months ago (2015-07-22 19:52:06 UTC) #4
ppi
+jamesr should be able to help with that
5 years, 5 months ago (2015-07-22 22:09:18 UTC) #6
jamesr
On 2015/07/22 at 19:52:06, kulakowski wrote: > On 2015/07/22 18:06:42, ppi wrote: > > lgtm ...
5 years, 5 months ago (2015-07-22 22:23:51 UTC) #7
kulakowski
On 2015/07/22 22:23:51, jamesr wrote: > On 2015/07/22 at 19:52:06, kulakowski wrote: > > On ...
5 years, 5 months ago (2015-07-22 22:27:39 UTC) #8
jamesr
You should be able to push now.
5 years, 5 months ago (2015-07-23 00:25:14 UTC) #9
kulakowski
On 2015/07/23 00:25:14, jamesr wrote: > You should be able to push now. This landed ...
5 years, 5 months ago (2015-07-23 00:43:01 UTC) #10
jamesr
On 2015/07/23 at 00:43:01, kulakowski wrote: > On 2015/07/23 00:25:14, jamesr wrote: > > You ...
5 years, 5 months ago (2015-07-23 00:44:53 UTC) #11
kulakowski
On 2015/07/23 00:44:53, jamesr wrote: > On 2015/07/23 at 00:43:01, kulakowski wrote: > > On ...
5 years, 5 months ago (2015-07-23 00:47:13 UTC) #12
jamesr
Hmm, OK. I wonder if the rietveld issue # was lost (it's normally stored as ...
5 years, 5 months ago (2015-07-23 00:48:24 UTC) #13
kulakowski
5 years, 5 months ago (2015-07-23 00:52:13 UTC) #14
Message was sent while issue was closed.
On 2015/07/23 00:48:24, jamesr wrote:
> Hmm, OK.  I wonder if the rietveld issue # was lost (it's normally stored as a
> git branch property).  If you see it failing to comment+close when landing in
> the future try to hang on to the output and branch data so we can debug.

That seems likely. I hit ^C at some point when checking out the patch on a
different computer, on a bad network connection. Thanks.

Powered by Google App Engine
This is Rietveld 408576698