Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1251423002: Update fallback rsqrt implementation to use optimal constants. (Closed)

Created:
5 years, 5 months ago by jvanverth1
Modified:
5 years, 5 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update fallback rsqrt implementation to use optimal constants. Improves max relative error from 0.00175126 to 0.000650197. Also add unit tests to check error bounds. BUG=chromium:511458 Committed: https://skia.googlesource.com/skia/+/29c69793f0201a5f221d6e0f3d41c1adbc4e5656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M include/core/SkFloatingPoint.h View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/MathTest.cpp View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
jvanverth1
5 years, 5 months ago (2015-07-23 17:16:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251423002/1
5 years, 5 months ago (2015-07-23 17:16:36 UTC) #4
mtklein
lgtm
5 years, 5 months ago (2015-07-23 17:18:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-23 18:00:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251423002/1
5 years, 5 months ago (2015-07-23 18:10:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1287)
5 years, 5 months ago (2015-07-23 18:10:59 UTC) #11
jvanverth1
Adding bsalomon@ for API approval.
5 years, 5 months ago (2015-07-23 18:12:08 UTC) #13
mtklein
On 2015/07/23 18:12:08, jvanverth1 wrote: > Adding bsalomon@ for API approval. (This is the sort ...
5 years, 5 months ago (2015-07-23 18:12:47 UTC) #14
bsalomon
On 2015/07/23 18:12:47, mtklein wrote: > On 2015/07/23 18:12:08, jvanverth1 wrote: > > Adding bsalomon@ ...
5 years, 5 months ago (2015-07-23 18:13:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251423002/1
5 years, 5 months ago (2015-07-23 18:14:07 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 18:14:31 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/29c69793f0201a5f221d6e0f3d41c1adbc4e5656

Powered by Google App Engine
This is Rietveld 408576698