Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1251363002: [test] Let test runner only use exact matches of tests on the cmd-line. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Let test runner only use exact matches of tests on the cmd-line. There are many test names in the v8 code base that prefix others, which makes it hard to only run those tests. BUG=chromium:511215 LOG=n NOTRY=true Committed: https://crrev.com/3bc1b1346afb368254f65a4f0e9bbd32322bb536 Cr-Commit-Position: refs/heads/master@{#29809}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M tools/testrunner/local/testsuite.py View 1 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251363002/1
5 years, 5 months ago (2015-07-23 12:29:26 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4389)
5 years, 5 months ago (2015-07-23 12:38:43 UTC) #5
Michael Achenbach
PTAL
5 years, 5 months ago (2015-07-23 12:41:31 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251363002/1
5 years, 5 months ago (2015-07-23 12:53:59 UTC) #8
Jakob Kummerow
LGTM! Thanks for fixing this; this has been on my to-do list for a long ...
5 years, 5 months ago (2015-07-23 12:55:47 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-23 12:56:13 UTC) #11
Michael Achenbach
https://codereview.chromium.org/1251363002/diff/1/tools/testrunner/local/testsuite.py File tools/testrunner/local/testsuite.py (right): https://codereview.chromium.org/1251363002/diff/1/tools/testrunner/local/testsuite.py#newcode180 tools/testrunner/local/testsuite.py:180: An argument with an asterisc in the end will ...
5 years, 5 months ago (2015-07-23 12:59:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251363002/20001
5 years, 5 months ago (2015-07-23 12:59:22 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-23 13:01:19 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 13:01:46 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3bc1b1346afb368254f65a4f0e9bbd32322bb536
Cr-Commit-Position: refs/heads/master@{#29809}

Powered by Google App Engine
This is Rietveld 408576698