infra/tools/antibody/git_commit_parser.py - Issue 1251323005: Changed parser to identify review urls following Reviewed-on:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/tools/antibody/git_commit_parser.py

Issue 1251323005: Changed parser to identify review urls following Reviewed-on: (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@antibody-stats-generator

Patch Set: Fixed indexing Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: infra/tools/antibody/git_commit_parser.py

diff --git a/infra/tools/antibody/git_commit_parser.py b/infra/tools/antibody/git_commit_parser.py

index 7510743aeb2551e3424586ce78193f58651e543c..75ab084eff8aedad19868dc26a0916721f8263a0 100644

--- a/infra/tools/antibody/git_commit_parser.py

+++ b/infra/tools/antibody/git_commit_parser.py

@@ -79,12 +79,14 @@ def get_tbr(git_line):

# identify the correct one

def get_review_url(git_line):

review_url = None

- if re.match(r'^Review:.+$', git_line):

+ if re.match(r'^Review: .+$', git_line):

review_url = git_line[8:]

- elif re.match(r'^Review URL:.+$', git_line):

+ elif re.match(r'^Review URL: .+$', git_line):

review_url = git_line[12:]

- elif re.match(r'^Code review URL:.+$', git_line):

+ elif re.match(r'^Code review URL: .+$', git_line):

review_url = git_line[17:]

+ elif re.match(r'^Reviewed-on: .+$', git_line):

+ review_url = git_line[12:]

pgervais 2015/07/23 20:35:54 13 here :-)

return review_url

« no previous file with comments | « no previous file | no next file » | no next file with comments »