Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: infra/tools/antibody/git_commit_parser.py

Issue 1251323005: Changed parser to identify review urls following Reviewed-on: (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@antibody-stats-generator
Patch Set: Fixed regexps Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/tools/antibody/git_commit_parser.py
diff --git a/infra/tools/antibody/git_commit_parser.py b/infra/tools/antibody/git_commit_parser.py
index 7510743aeb2551e3424586ce78193f58651e543c..7dbd6ef5dce4a2b3e9a9cc7090c5eacc0a6e6eb5 100644
--- a/infra/tools/antibody/git_commit_parser.py
+++ b/infra/tools/antibody/git_commit_parser.py
@@ -79,12 +79,14 @@ def get_tbr(git_line):
# identify the correct one
def get_review_url(git_line):
review_url = None
- if re.match(r'^Review:.+$', git_line):
- review_url = git_line[8:]
- elif re.match(r'^Review URL:.+$', git_line):
+ if re.match(r'^Review: .+$', git_line):
+ review_url = git_line[7:]
+ elif re.match(r'^Review URL: .+$', git_line):
+ review_url = git_line[11:]
+ elif re.match(r'^Code review URL: .+$', git_line):
+ review_url = git_line[16:]
+ elif re.match(r'^Reviewed-on: .+$', git_line):
review_url = git_line[12:]
pgervais 2015/07/23 18:50:55 This is consistent but the number in git_line shou
- elif re.match(r'^Code review URL:.+$', git_line):
- review_url = git_line[17:]
return review_url
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698