Changed parser to identify review urls following Reviewed-on:

Changed parser to identify review urls following Reviewed-on:

BUG=513379
Committed: https://chromium.googlesource.com/infra/infra/+/ba85ab855f65c05e24009f735295a976740627ef

[keelerh, 2015-07-23 18:27:04]

keelerh@google.com changed reviewers:
+ hinoka@chromium.org, ksho@google.com, pgervais@chromium.org

[pgervais, 2015-07-23 18:30:36]

https://codereview.chromium.org/1251323005/diff/1/infra/tools/antibody/git_co...
File infra/tools/antibody/git_commit_parser.py (right):

https://codereview.chromium.org/1251323005/diff/1/infra/tools/antibody/git_co...
infra/tools/antibody/git_commit_parser.py:89: review_url = git_line[13:]
13 or 12? If there is a space after the colon, please add it to the regexp.

[keelerh, 2015-07-23 18:35:54]

On 2015/07/23 at 18:30:36, pgervais wrote:
>
https://codereview.chromium.org/1251323005/diff/1/infra/tools/antibody/git_co...
> File infra/tools/antibody/git_commit_parser.py (right):
> 
>
https://codereview.chromium.org/1251323005/diff/1/infra/tools/antibody/git_co...
> infra/tools/antibody/git_commit_parser.py:89: review_url = git_line[13:]
> 13 or 12? If there is a space after the colon, please add it to the regexp.

It's 13, and I don't know much about regexps, Ryan helped me right these, but I
tested it with the commits and this parses the url correctly. Is there a better
way to write the expression?

>>> git_line = 'Reviewed-on: https://chromium-review.googlesource.com/286530'
>>> if re.match(r'^Reviewed-on:.+$', git_line):
...     print git_line[13:]
... 
https://chromium-review.googlesource.com/286530

[pgervais, 2015-07-23 18:38:41]

On 2015/07/23 18:35:54, keelerh wrote:
> On 2015/07/23 at 18:30:36, pgervais wrote:
> >
>
https://codereview.chromium.org/1251323005/diff/1/infra/tools/antibody/git_co...
> > File infra/tools/antibody/git_commit_parser.py (right):
> > 
> >
>
https://codereview.chromium.org/1251323005/diff/1/infra/tools/antibody/git_co...
> > infra/tools/antibody/git_commit_parser.py:89: review_url = git_line[13:]
> > 13 or 12? If there is a space after the colon, please add it to the regexp.
> 
> It's 13, and I don't know much about regexps, Ryan helped me right these, but
I
> tested it with the commits and this parses the url correctly. Is there a
better
> way to write the expression?
> 
> >>> git_line = 'Reviewed-on: https://chromium-review.googlesource.com/286530
> >>> if re.match(r'^Reviewed-on:.+$', git_line):
> ...     print git_line[13:]
> ... 

I meant:
if re.match(r'^Reviewed-on: .+$', git_line):

I added a space after the colon: 'Reviewed-on:' this is 12-character long.

[pgervais, 2015-07-23 18:50:55]

https://codereview.chromium.org/1251323005/diff/20001/infra/tools/antibody/gi...
File infra/tools/antibody/git_commit_parser.py (right):

https://codereview.chromium.org/1251323005/diff/20001/infra/tools/antibody/gi...
infra/tools/antibody/git_commit_parser.py:89: review_url = git_line[12:]
This is consistent but the number in git_line should match the number of
characters in the regexps. 
Example:
'^Review: .+$' essentially matches 'Review: ' at the beginning of a line
(because there is ^ at the beginning), with anything afterward. 'Review: ' is 8
characters long, so line 83 should read
review_url = git_line[8:]

Same for the other lines (just add one everywhere).

[pgervais, 2015-07-23 20:35:54]

lgtm with one last nit

https://codereview.chromium.org/1251323005/diff/40001/infra/tools/antibody/gi...
File infra/tools/antibody/git_commit_parser.py (right):

https://codereview.chromium.org/1251323005/diff/40001/infra/tools/antibody/gi...
infra/tools/antibody/git_commit_parser.py:89: review_url = git_line[12:]
13 here :-)

[keelerh, 2015-07-23 21:46:59]

The CQ bit was checked by keelerh@google.com

[keelerh, 2015-07-23 21:46:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
pgervais@chromium.org
Link to the patchset: https://codereview.chromium.org/1251323005/#ps60001
(title: "Fixed last index error")

[commit-bot: I haz the power, 2015-07-23 21:47:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251323005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251323005/60001

[commit-bot: I haz the power, 2015-07-23 21:52:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-23 21:52:56]

Try jobs failed on following builders:
  infra_tester on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[keelerh, 2015-07-23 22:00:43]

The CQ bit was checked by keelerh@google.com

[keelerh, 2015-07-23 22:00:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
pgervais@chromium.org
Link to the patchset: https://codereview.chromium.org/1251323005/#ps80001
(title: "Updated test data for 100% coverage")

[commit-bot: I haz the power, 2015-07-23 22:00:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251323005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251323005/80001

[commit-bot: I haz the power, 2015-07-23 22:03:38]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/ba85ab855f65c05e24009f735295a...