content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 1251323002: Plumb smooth scrolling in Chromium compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 1251323002: Plumb smooth scrolling in Chromium compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use a blink page scale animation Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('K') | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | content/public/android/java/src/org/chromium/content_public/browser/GestureStateListener.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index 0f23bcda766c332bec3cbf16673ac8da8b5e75e6..5694679a60271ee25edc45ca48c1515dae7a8e2e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -262,6 +262,11 @@ import java.util.UUID;

}

@Override

+ public void smoothScroll(int targetX, int targetY, long durationMs) {

+ nativeSmoothScroll(mNativeWebContentsAndroid, targetX, targetY, durationMs);

+ }

+ @Override

public void selectWordAroundCaret() {

nativeSelectWordAroundCaret(mNativeWebContentsAndroid);

}

@@ -417,6 +422,8 @@ import java.util.UUID;

boolean enableHiding, boolean enableShowing, boolean animate);

private native void nativeShowImeIfNeeded(long nativeWebContentsAndroid);

private native void nativeScrollFocusedEditableNodeIntoView(long nativeWebContentsAndroid);

+ private native void nativeSmoothScroll(

+ long nativeWebContentsAndroid, int targetX, int targetY, long durationMs);

private native void nativeSelectWordAroundCaret(long nativeWebContentsAndroid);

private native void nativeAdjustSelectionByCharacterOffset(

long nativeWebContentsAndroid, int startAdjust, int endAdjust);