Issue 12513014: POSIX: surround statvfs calls with HANDLE_EINTR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12513014: POSIX: surround statvfs calls with HANDLE_EINTR (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.

Modified:
7 years, 9 months ago

Reviewers:
Mark Mentovai, satorux1

CC:
chromium-reviews, nkostylev+watch_chromium.org, sail+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

POSIX: surround statvfs calls with HANDLE_EINTR BUG=222610 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190451

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	base/sys_info_posix.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/12513014/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): https://codereview.chromium.org/12513014/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode294 chrome/browser/chromeos/extensions/file_browser_private_api.cc:294: struct statvfs stat = {}; // Zero-clear You ...

7 years, 9 months ago (2013-03-22 22:17:39 UTC) #2

Paweł Hajdan Jr.

7 years, 9 months ago (2013-03-25 19:03:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r190451 (presubmit successful).

Expand Messages | Collapse Messages