Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 12513008: Android: use gcc (not cpp) to preprocess templates. (Closed)

Created:
7 years, 9 months ago by Torne
Modified:
7 years, 9 months ago
Reviewers:
bulach
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Android: use gcc (not cpp) to preprocess templates. When building the WebView on macs, cpp is a wrapper script around llvm which does not accept all the same arguments as the cpp that's part of gcc. Invoke gcc -E instead, which should be guaranteed to accept gcc arguments (even if it ultimately invokes llvm as well). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/android/java_cpp_template.gypi View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Torne
Hi Marcus, Rather than try to invoke the target cpp (which I can't work out ...
7 years, 9 months ago (2013-03-06 11:35:30 UTC) #1
bulach
lgtm, seems fine by me and the bots look healthy, thanks!
7 years, 9 months ago (2013-03-06 15:05:17 UTC) #2
Torne
7 years, 9 months ago (2013-03-06 15:11:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r186439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698