Fix warnings in dart2js code and re-enable analyzer coverage.

sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
index f93187c80de9e47761e65bf975446c6ea09a9da2..c04a50ba09c8c1fa9d88a4f0fa9ffb2f2e20961e 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
@@ -1178,7 +1178,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
                              Node callNode) {
     compiler.withCurrentElement(constructor, () {
       assert(invariant(constructor, constructor.isImplementation));
-      constructors.addLast(constructor);
+      constructors.add(constructor);
 
       List<HInstruction> compiledArguments = new List<HInstruction>();
       bool succeeded =
@@ -1201,7 +1201,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
         // type parameters. Those values are in the [supertype]
         // declaration of [subclass].
         ClassElement subclass = inlinedFromElement.getEnclosingClass();
-        DartType supertype = subclass.supertype;
+        GenericType supertype = subclass.supertype;

[karlklose, 2013/03/06 09:48:21]

You could instead change the type of ClassElement.supertype to InterfaceType and
inline supertype.

         Link<DartType> typeVariables = superclass.typeVariables;
         supertype.typeArguments.forEach((DartType argument) {
           localsHandler.updateLocal(typeVariables.head.element,
@@ -4102,8 +4102,8 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
          !link.isEmpty;
          link = link.tail) {
       visit(link.head);
-      inputs.addLast(pop());
-      inputs.addLast(pop());
+      inputs.add(pop());
+      inputs.add(pop());
     }
     HLiteralList keyValuePairs = new HLiteralList(inputs);
     add(keyValuePairs);