Remove legacy CRD application types.

Remove legacy CRD application types.

1. Removed CRD v1 app.
2. Removed support for native plugin from the webapp.

Committed: https://crrev.com/a7471f6cb51311f9e8841dcce67ee425914e81ad
Cr-Commit-Position: refs/heads/master@{#341794}

[Sergey Ulanov, 2015-07-22 20:52:14]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org, kerz@chromium.org

[kerz_chromium, 2015-07-22 20:57:18]

LGTM for Files.*

[Sergey Ulanov, 2015-07-22 21:02:48]

The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-22 21:03:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251273002/1

[Jamie, 2015-07-22 21:26:05]

jamiewalch@chromium.org changed reviewers:
+ kelvinp@chromium.org

[Jamie, 2015-07-22 21:26:06]

I'll defer to Kelvin as to whether or not we still need the plugin for app
streaming--he was looking into this recently.

[commit-bot: I haz the power, 2015-07-22 21:44:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-22 21:44:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kelvinp, 2015-07-22 22:09:02]

The v1 app is currently the only way for us to validate against a test server
instance.  Should we hold this off until we figure out how to run the v2 app
against the test server?

[Sergey Ulanov, 2015-07-22 23:40:35]

On 2015/07/22 22:09:02, kelvinp wrote:
> The v1 app is currently the only way for us to validate against a test server
> instance.  Should we hold this off until we figure out how to run the v2 app
> against the test server?

That's sad. v1 doesn't work with PNaCl, which means we have to keep packaging
the plugin into chrome just for tests. Are there many tests running v1 app? Can
we disable them temporarily?

[kelvinp, 2015-07-23 17:08:08]

kelvinp@chromium.org changed reviewers:
+ anandc@chromium.org

[kelvinp, 2015-07-23 17:08:09]

+Anandc

[anandc, 2015-07-23 17:27:54]

On 2015/07/23 17:08:09, kelvinp wrote:
> +Anandc

Could you please also remove this line in the test isolate file:
https://code.google.com/p/chromium/codesearch#chromium/src/testing/chromoting...
?
Other than that, and the update you've already made to dependencies.gypi, there
are no references to the v1 web-app for tests that run on the Chromoting
waterfall. We now only run tests with the v2 web-app.

kelvinp@ is referring to validating updates to the Chromoting directory server
by verifying a web-app pointing to the server's test instance. I'm not sure what
updates are required to get the v2 web-app working for that. It would be good to
get that figured out: https://code.google.com/p/chromium/issues/detail?id=513337
tracks this work.

[Sergey Ulanov, 2015-07-23 18:41:57]

On 2015/07/23 17:27:54, anandc wrote:
> On 2015/07/23 17:08:09, kelvinp wrote:
> > +Anandc
> 
> Could you please also remove this line in the test isolate file:
>
https://code.google.com/p/chromium/codesearch#chromium/src/testing/chromoting...
> ?
> Other than that, and the update you've already made to dependencies.gypi,
there
> are no references to the v1 web-app for tests that run on the Chromoting
> waterfall. We now only run tests with the v2 web-app.

Done.

> 
> kelvinp@ is referring to validating updates to the Chromoting directory server
> by verifying a web-app pointing to the server's test instance. I'm not sure
what
> updates are required to get the v2 web-app working for that. It would be good
to
> get that figured out:
https://code.google.com/p/chromium/issues/detail?id=513337
> tracks this work.

[Sergey Ulanov, 2015-07-30 16:46:37]

Kelvin, ping :)
Any progress getting V2 app running with test servers?

[kelvinp, 2015-07-30 18:34:14]

On 2015/07/30 16:46:37, Sergey Ulanov wrote:
> Kelvin, ping :)
> Any progress getting V2 app running with test servers?

Yes, we need two CL's to run our v2 app with our test server.
One of them is already out for review: 
https://chromereviews.googleplex.com/229367013/
The other way is working locally on my box and I am sending it out today.

[Sergey Ulanov, 2015-07-30 21:21:27]

On 2015/07/30 18:34:14, kelvinp wrote:
> On 2015/07/30 16:46:37, Sergey Ulanov wrote:
> > Kelvin, ping :)
> > Any progress getting V2 app running with test servers?
> 
> Yes, we need two CL's to run our v2 app with our test server.
> One of them is already out for review: 
> https://chromereviews.googleplex.com/229367013/
> The other way is working locally on my box and I am sending it out today.

Does that work need to block this CL?

[kelvinp, 2015-08-03 20:27:12]

lgtm once my comments are addressed.

https://codereview.chromium.org/1251273002/diff/20001/remoting/webapp/build-w...
File remoting/webapp/build-webapp.py (left):

https://codereview.chromium.org/1251273002/diff/20001/remoting/webapp/build-w...
remoting/webapp/build-webapp.py:223: is_desktop_remoting = not is_app_remoting
This file is out-of-date.

There is a getClientPluginType function that needs to be updated as well.

[Sergey Ulanov, 2015-08-03 20:40:34]

https://codereview.chromium.org/1251273002/diff/20001/remoting/webapp/build-w...
File remoting/webapp/build-webapp.py (left):

https://codereview.chromium.org/1251273002/diff/20001/remoting/webapp/build-w...
remoting/webapp/build-webapp.py:223: is_desktop_remoting = not is_app_remoting
On 2015/08/03 20:27:12, kelvinp wrote:
> This file is out-of-date.
> 
> There is a getClientPluginType function that needs to be updated as well.

Removed getClientPluginType() now

[Sergey Ulanov, 2015-08-03 20:40:55]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-08-03 20:40:56]

The patchset sent to the CQ was uploaded after l-g-t-m from kerz@chromium.org,
kelvinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1251273002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-03 20:41:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251273002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251273002/40001

[commit-bot: I haz the power, 2015-08-03 22:59:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-03 23:00:18]

Patchset 3 (id:??) landed as
https://crrev.com/05307a4945bddaa382c4073c2fb149143545c025
Cr-Commit-Position: refs/heads/master@{#341635}

[Sergey Ulanov, 2015-08-04 18:32:03]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-08-04 18:32:04]

The patchset sent to the CQ was uploaded after l-g-t-m from kerz@chromium.org,
kelvinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1251273002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-08-04 18:33:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251273002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251273002/80001

[commit-bot: I haz the power, 2015-08-04 19:18:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 19:18:15]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sergey Ulanov, 2015-08-04 20:04:48]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-08-04 20:05:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251273002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251273002/80001

[commit-bot: I haz the power, 2015-08-04 21:08:02]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-04 21:11:48]

Patchset 5 (id:??) landed as
https://crrev.com/a7471f6cb51311f9e8841dcce67ee425914e81ad
Cr-Commit-Position: refs/heads/master@{#341794}