content/public/browser/download_manager.h - Issue 1251243003: Support restricting browsing data removal for downloads by origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/download_manager.h

Issue 1251243003: Support restricting browsing data removal for downloads by origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_manager_impl.h ('K') | « content/browser/download/download_manager_impl_unittest.cc ('k') | content/public/test/mock_download_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/download_manager.h

diff --git a/content/public/browser/download_manager.h b/content/public/browser/download_manager.h

index 74cb77d6d4da6560517efca3dfff1fec8c1a8a39..b0ae98813a42484b1b2ce814ddb2372f3abe5476 100644

--- a/content/public/browser/download_manager.h

+++ b/content/public/browser/download_manager.h

@@ -27,6 +27,7 @@

#ifndef CONTENT_PUBLIC_BROWSER_DOWNLOAD_MANAGER_H_

#define CONTENT_PUBLIC_BROWSER_DOWNLOAD_MANAGER_H_

+#include <set>

#include <string>

#include <vector>

@@ -113,7 +114,8 @@ class CONTENT_EXPORT DownloadManager : public base::SupportsUserData::Data {

// Remove downloads after remove_begin (inclusive) and before remove_end

Mike West 2015/07/22 20:16:03 Poke at the comment to describe the new parameter.

Timo Reimann 2015/07/23 23:11:07 Done.

// (exclusive). You may pass in null Time values to do an unbounded delete

// in either direction.

- virtual int RemoveDownloadsBetween(base::Time remove_begin,

+ virtual int RemoveDownloadsBetween(const std::set<GURL>& restricted_urls,

+ base::Time remove_begin,

base::Time remove_end) = 0;

// Remove downloads will delete all downloads that have a timestamp that is