Support restricting browsing data removal for downloads by origin.

content/browser/download/download_manager_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include <string>
 
 #include "base/bind.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 19 matching lines @@
 #include "content/public/browser/download_manager_delegate.h"
 #include "content/public/browser/zoom_level_delegate.h"
 #include "content/public/test/mock_download_item.h"
 #include "content/public/test/test_browser_context.h"
 #include "content/public/test/test_browser_thread.h"
 #include "net/base/net_util.h"
 #include "net/log/net_log.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gmock_mutant.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "url/origin.h"
 
 using ::testing::AllOf;
 using ::testing::DoAll;
 using ::testing::Eq;
 using ::testing::Ref;
 using ::testing::Return;
 using ::testing::ReturnRef;
 using ::testing::SetArgPointee;
 using ::testing::StrictMock;
 using ::testing::_;
@@ skipping 388 matching lines @@
   MOCK_METHOD2(SelectFileDialogDisplayed, void(
         DownloadManager*, int32));
 };
 
 }  // namespace
 
 class DownloadManagerTest : public testing::Test {
  public:
   static const char* kTestData;
   static const size_t kTestDataLen;
+  std::vector<GURL> download_urls;
 
   DownloadManagerTest()
       : callback_called_(false),
         ui_thread_(BrowserThread::UI, &message_loop_),
         file_thread_(BrowserThread::FILE, &message_loop_),
         next_download_id_(0) {
+    download_urls.push_back(GURL("http://www.url1.com"));
+    download_urls.push_back(GURL("http://www.url2.com"));
+    download_urls.push_back(GURL("http://www.url3.com"));
+    download_urls.push_back(GURL("http://www.url4.com"));
   }
 
   // We tear down everything in TearDown().
   ~DownloadManagerTest() override {}
 
   // Create a MockDownloadItemFactory and MockDownloadManagerDelegate,
   // then create a DownloadManager that points
   // at all of those.
   void SetUp() override {
     DCHECK(!download_manager_);
@@ skipping 50 matching lines @@
     ++next_download_id_;
     info.request_handle = DownloadRequestHandle();
     download_manager_->CreateActiveItem(id, info);
     DCHECK(mock_download_item_factory_->GetItem(id));
     MockDownloadItemImpl& item(*mock_download_item_factory_->GetItem(id));
     // Satisfy expectation.  If the item is created in StartDownload(),
     // we call Start on it immediately, so we need to set that expectation
     // in the factory.
     scoped_ptr<DownloadRequestHandleInterface> req_handle;
     item.Start(scoped_ptr<DownloadFile>(), req_handle.Pass());
+    DCHECK(id < download_urls.size());
+    EXPECT_CALL(item, GetURL()).WillRepeatedly(ReturnRef(download_urls[id]));
 
     return item;
   }
 
   MockDownloadItemImpl& GetMockDownloadItem(int id) {
     MockDownloadItemImpl* itemp = mock_download_item_factory_->GetItem(id);
 
     DCHECK(itemp);
     return *itemp;
   }
@@ skipping 153 matching lines @@
   EXPECT_CALL(GetMockDownloadItem(2), Remove())
       .WillOnce(Return());
   EXPECT_CALL(GetMockDownloadItem(3), Remove())
       .Times(0);
 
   download_manager_->RemoveAllDownloads();
   // Because we're mocking the download item, the Remove call doesn't
   // result in them being removed from the DownloadManager list.
 }
 
+// Confirm that only downloads with same origin are removed.
+TEST_F(DownloadManagerTest, RemoveSameOriginDownloads) {
+  base::Time now(base::Time::Now());
+  for (uint32 i = 0; i < 2; ++i) {
+    MockDownloadItemImpl& item(AddItemToManager());
+    EXPECT_CALL(item, GetStartTime()).WillRepeatedly(Return(now));
+    EXPECT_CALL(item, GetState())
+        .WillRepeatedly(Return(DownloadItem::COMPLETE));
+  }
+
+  EXPECT_CALL(GetMockDownloadItem(0), Remove());

[Randy Smith (Not in Mondays), 2015/08/05 16:02:04]

Do you need a
::testing::Mock::VerifyAndClearExpectations(GetMockDownloadItem(0)) at some
point later in this function to make sure that this call actually happened?

[Timo Reimann, 2015/08/05 20:07:46]

I notice that none of the other (similar looking) tests is using
VerifyAndClearExpectations. Do you think it's something that just the new test
should do for some specific reason, or rather all tests in general? The existing
tests seem to rely on the mock fixture to do proper cleanup to ensure
expectation verification.

+  EXPECT_CALL(GetMockDownloadItem(1), Remove()).Times(0);
+
+  url::Origin origin_to_clear(download_urls[0]);
+  int remove_count = download_manager_->RemoveDownloadsByOriginAndTime(
+      origin_to_clear, base::Time(), base::Time::Max());
+  EXPECT_EQ(remove_count, 1);
+}
+
 }  // namespace content