Support restricting browsing data removal for downloads by origin.

content/browser/download/download_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_manager_impl.h"
 
 #include <iterator>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 26 matching lines @@
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/resource_context.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/common/referrer.h"
 #include "net/base/elements_upload_data_stream.h"
 #include "net/base/load_flags.h"
 #include "net/base/request_priority.h"
 #include "net/base/upload_bytes_element_reader.h"
 #include "net/url_request/url_request_context.h"
+#include "url/origin.h"
 
 namespace content {
 namespace {
 
 void BeginDownload(scoped_ptr<DownloadUrlParameters> params,
                    uint32 download_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   // ResourceDispatcherHost{Base} is-not-a URLRequest::Delegate, and
   // DownloadUrlParameters can-not include resource_dispatcher_host_impl.h, so
   // we must down cast. RDHI is the only subclass of RDH as of 2012 May 4.
@@ skipping 501 matching lines @@
 void DownloadManagerImpl::DownloadRemoved(DownloadItemImpl* download) {
   if (!download)
     return;
 
   uint32 download_id = download->GetId();
   if (downloads_.erase(download_id) == 0)
     return;
   delete download;
 }
 
-int DownloadManagerImpl::RemoveDownloadsBetween(base::Time remove_begin,
-                                                base::Time remove_end) {
+// Determines if the given URL should be removed. This is the case for URLs
+// that are same-origin with the given origin or where the given origin is
+// unique. The latter marks a sitation where we intend to clear all URLs.
+static bool IsRemovableURL(const GURL& url,

[Bernhard Bauer, 2015/08/04 07:49:20]

Move this into an anonymous namespace instead of declaring it as static.

[Timo Reimann, 2015/08/04 15:00:26]

Originally, I had it in an anonymous namespace and accidentally moved it out
again when I addressed phajdan.jr's concern to locate the function closer to the
call site.

I could wrap it in an anonymous namespace again where it is now, but that would
lead to the file having two anonymous namespaces (one at the very top and
another one just to accommodate IsRemovableURL). Not sure if this is common
practice in Chromium though.

If it's not, then I suggest we wait until I have resolved rdsmith's points. This
will likely end up in another refactoring of DownloadManager and friends,
thereby possibly rendering the function in question obsolete. WDYT?

[Bernhard Bauer, 2015/08/04 15:05:06]

I have seen separate anonymous namespaces; I don't think that's a big problem
(unless you subscribe to the notion that everything local to the file should
come before the stuff that's declared in the header, but that would directly
contradict what Paweł suggested, and it would equally apply to static vs.
anonymous namespace).

+                           const url::Origin& origin_to_clear) {
+  url::Origin url_origin(url);
+
+  return origin_to_clear.unique() ||
+         origin_to_clear.IsSameOriginWith(url_origin);
+}
+
+int DownloadManagerImpl::RemoveDownloadsBetween(
+    const url::Origin& origin_to_clear,
+    base::Time remove_begin,
+    base::Time remove_end) {
   int count = 0;
   DownloadMap::const_iterator it = downloads_.begin();
   while (it != downloads_.end()) {
     DownloadItemImpl* download = it->second;
 
     // Increment done here to protect against invalidation below.
     ++it;
 
-    if (download->GetStartTime() >= remove_begin &&
+    if (IsRemovableURL(download->GetURL(), origin_to_clear) &&
+        download->GetStartTime() >= remove_begin &&
         (remove_end.is_null() || download->GetStartTime() < remove_end) &&
         (download->GetState() != DownloadItem::IN_PROGRESS)) {
       // Erases the download from downloads_.
       download->Remove();
       count++;
     }
   }
   return count;
 }
 
 int DownloadManagerImpl::RemoveDownloads(base::Time remove_begin) {
-  return RemoveDownloadsBetween(remove_begin, base::Time());
+  return RemoveDownloadsBetween(url::Origin(), remove_begin, base::Time());
 }
 
 int DownloadManagerImpl::RemoveAllDownloads() {
   // The null times make the date range unbounded.
-  int num_deleted = RemoveDownloadsBetween(base::Time(), base::Time());
+  int num_deleted =
+      RemoveDownloadsBetween(url::Origin(), base::Time(), base::Time());
   RecordClearAllSize(num_deleted);
   return num_deleted;
 }
 
 void DownloadManagerImpl::DownloadUrl(
     scoped_ptr<DownloadUrlParameters> params) {
   if (params->post_id() >= 0) {
     // Check this here so that the traceback is more useful.
     DCHECK(params->prefer_cache());
     DCHECK_EQ("POST", params->method());
@@ skipping 110 matching lines @@
   if (delegate_)
     delegate_->OpenDownload(download);
 }
 
 void DownloadManagerImpl::ShowDownloadInShell(DownloadItemImpl* download) {
   if (delegate_)
     delegate_->ShowDownloadInShell(download);
 }
 
 }  // namespace content