[tracing] Fix, simplify and speed up accounting of TraceEvent memory overhead

[tracing] Fix, simplify and speed up accounting of TraceEvent memory overhead

So far the accounting of TraceEvent memory overhead worked as follows:
 - Each TraceEvent keeps a cache of its own overhead.
 - The TraceBufferChunk (which is approx an array of 64 TraceEvent)
   keeps a cache of the all 64 TraceEvent, but only when completelly
   filled.

This is sub-optimal because:
 - There can be many TraceEvent(s), 10k-100k in a bulky 30s trace:
   when memory-infra is enabled, this causes a cost of several MB to
   keep the aforementioned per-TraceEvent caches.
 - Every time we have to estimate the size of a non-completely-full
   TraceBufferChunk, we still have to loop over their individual caches.
 - Least but not last, turns out that the current accounting is just
   wrong, as we ended up counting the sizeof(TraceEvent) both in
   TraceBufferChunk and in the individual TraceEvent.

This CL improves the situation as follows:
 - The per-TraceEvent cache is dropped. Much less memory is used.
 - The TraceBufferChunk still keeps a cache, but its cache is used in a
   smarter way and not just when it is full. We simply remember how many
   TraceEvent(s) we estimated in the previous pass and then estimate just
   the missing ones.
 - The double accounting issue is fixed, as now we count TraceEvent(s)
   only in TraceBufferChunk.

BUG=512383
Committed: https://crrev.com/b2ae97fb331cbad132a8e1aad9a25441fde75048
Cr-Commit-Position: refs/heads/master@{#340005}

[Primiano Tucci (use gerrit), 2015-07-22 19:52:41]

primiano@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Primiano Tucci (use gerrit), 2015-07-22 19:52:41]

PTAL

[dsinclair, 2015-07-22 20:37:31]

lgtm w/ nit

https://codereview.chromium.org/1251203003/diff/20001/base/trace_event/trace_...
File base/trace_event/trace_event_impl.cc (right):

https://codereview.chromium.org/1251203003/diff/20001/base/trace_event/trace_...
base/trace_event/trace_event_impl.cc:491: // computed on the flight.
nit: s/flight/fly

[Primiano Tucci (use gerrit), 2015-07-22 21:55:23]

https://codereview.chromium.org/1251203003/diff/20001/base/trace_event/trace_...
File base/trace_event/trace_event_impl.cc (right):

https://codereview.chromium.org/1251203003/diff/20001/base/trace_event/trace_...
base/trace_event/trace_event_impl.cc:491: // computed on the flight.
On 2015/07/22 20:37:31, dsinclair wrote:
> nit: s/flight/fly

Oh.My mind is already in vacation mode, I guess I was thinking about how joyful
I'll be when catching a flight tomorrow :P

Done.

[Primiano Tucci (use gerrit), 2015-07-22 21:55:27]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-07-22 21:55:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/1251203003/#ps60001
(title: "Get rid of rendundant check")

[commit-bot: I haz the power, 2015-07-22 21:58:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251203003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251203003/60001

[commit-bot: I haz the power, 2015-07-23 00:26:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-23 00:27:10]

Patchset 4 (id:??) landed as
https://crrev.com/b2ae97fb331cbad132a8e1aad9a25441fde75048
Cr-Commit-Position: refs/heads/master@{#340005}

[oystein (OOO til 10th of July), 2015-08-04 20:16:13]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1258903003/ by oysteine@chromium.org.

The reason for reverting is: Speculative revert for
https://code.google.com/p/chromium/issues/detail?id=516056.