Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: Source/WebCore/bindings/v8/V8LazyEventListener.cpp

Issue 12512013: Merge 146344 "[v8] unsafe persistent access in V8LazyEventListener" (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1447/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/bindings/v8/V8LazyEventListener.cpp
===================================================================
--- Source/WebCore/bindings/v8/V8LazyEventListener.cpp (revision 146369)
+++ Source/WebCore/bindings/v8/V8LazyEventListener.cpp (working copy)
@@ -70,7 +70,7 @@
v8::Handle<v8::Value> value = toV8(domObject, v8::Handle<v8::Object>(), isolate);
if (value.IsEmpty())
return v8::Object::New();
- return value.As<v8::Object>();
+ return v8::Local<v8::Object>::New(isolate, value.As<v8::Object>());
}
v8::Local<v8::Value> V8LazyEventListener::callListenerFunction(ScriptExecutionContext* context, v8::Handle<v8::Value> jsEvent, Event* event)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698