Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1251173003: Fix alpha pre-multiplication error with custom cursor images (Closed)

Created:
5 years, 5 months ago by Justin Novosad
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix alpha pre-multiplication error with custom cursor images Blink provides custom cursor images in alpha premultiplied form while the platform cursor code assumes that the raw image data will not be pre-multiplied. Skia is now pre-multiply aware, but the pickle format use for serializing the skia images over IPC has no notion of pre-multiplication. This fix solves the issue by converting the bimaps to unpremultiplied form prior to serialization. The skia image info of the source image is checked to determine whether conversion is necessary. BUG=432043 TEST=content_unittest WebCursorTest.AlphaConversion R=jochen@chromium.org Committed: https://crrev.com/cd0a8ae72380dc461eea58084325d9d981942192 Cr-Commit-Position: refs/heads/master@{#340097}

Patch Set 1 #

Patch Set 2 : windows build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -6 lines) Patch
M content/common/cursors/webcursor.cc View 1 2 chunks +9 lines, -4 lines 0 comments Download
M content/common/cursors/webcursor_unittest.cc View 3 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Justin Novosad
PTAL
5 years, 5 months ago (2015-07-22 18:36:30 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-23 09:17:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251173003/20001
5 years, 5 months ago (2015-07-23 14:39:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-23 15:26:16 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 15:26:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd0a8ae72380dc461eea58084325d9d981942192
Cr-Commit-Position: refs/heads/master@{#340097}

Powered by Google App Engine
This is Rietveld 408576698