Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 125115: Added mutation of locals to debugger (Closed)

Created:
11 years, 6 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added mutation of locals to debugger. The locals can now be mutated in the debugger. After a debugger evaluation the content of the scope created for the evaluation is written back to where it was originally picked from (context extension, context, stack locals, stack parameters and possibly adaptor frame stack parameters). Fixed an issue of evaluating arguments through arguments[n] in the debugger in some senarios. If n was larger than the functions formal parameters count and the arguments object was not used by the function arguments[n] used to resolve to undefined, as the precense of an arguments adaptor frame was not taken into account. Now all the passed parameters are added to the arguments object which is sometimes created for the evaluation function. If there is an arguments adaptor frame the arguments are picked from there. BUG=212 TEST=test\mjsunit\debug-evaluate.js

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -30 lines) Patch
M src/frames.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/frames.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 6 chunks +120 lines, -12 lines 0 comments Download
M test/mjsunit/debug-evaluate.js View 1 2 chunks +171 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Thygesen Gjesse
11 years, 6 months ago (2009-06-15 08:51:33 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/125115/diff/1/4 File src/runtime.cc (right): http://codereview.chromium.org/125115/diff/1/4#newcode6165 Line 6165: // Write back the to the local ...
11 years, 6 months ago (2009-06-15 11:48:28 UTC) #2
Kevin Millikin (Chromium)
As we discussed a bit offline, this will not work as-is right now. The code ...
11 years, 6 months ago (2009-06-15 12:15:23 UTC) #3
Søren Thygesen Gjesse
I will hold back this change until we have a safe way of leaving the ...
11 years, 6 months ago (2009-06-15 12:37:11 UTC) #4
Søren Thygesen Gjesse
11 years, 6 months ago (2009-06-15 14:05:21 UTC) #5
Added two tests which exposes some of the issues of providing wrong results and
throwing unexpected runtime exceptions from the runtime system. No hard crashes
has yet been found with the current level of optimizations.

Powered by Google App Engine
This is Rietveld 408576698