Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 1251083002: dart2js cps: Avoid deep recursion using trampolines and basic blocks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
index 63d1a05355ba8a9d7381f3f0d3c9f9e3193ecd3d..f07a03005ffdc30b24750bc064f0190201e66c81 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
@@ -92,7 +92,9 @@ class BlockCollector extends StatementVisitor {
visitBreak(Break node) {
_addStatement(node);
- blocks.last.addEdgeTo(breakTargets[node.target]);
+ if (breakTargets.containsKey(node.target)) {
+ blocks.last.addEdgeTo(breakTargets[node.target]);
+ }
}
visitContinue(Continue node) {
@@ -274,7 +276,9 @@ class TreeTracer extends TracerUtil with StatementVisitor {
}
visitBreak(Break node) {
- printStatement(null, "break ${collector.breakTargets[node.target].name}");
+ Block block = collector.breakTargets[node.target];
+ String name = block != null ? block.name : '<missing label>';
+ printStatement(null, "break $name");
}
visitContinue(Continue node) {
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698