Remove .rc files that are in resources.pak from test sources.

Remove .rc files that are in resources.pak from test sources.

Since these tests run on non-Windows platforms, the pak file seems to be loaded
fine and these .rc files should not be necessary.

BUG=297672
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243503

[oshima, 2014-01-06 23:40:28]

+sail

My understanding is that unscaled resources should be loaded as rc files on
Windows, although I may be wrong. sail should know for sure (or should know who
should know now).

[Nico, 2014-01-07 16:18:39]

Thanks for the quick review!

On 2014/01/06 23:40:28, oshima wrote:
> +sail

sail is sadly no longer working on chrome.

> My understanding is that unscaled resources should be loaded as rc files on
> Windows, although I may be wrong. sail should know for sure (or should know
who
> should know now).

There are two foo_unscaled_resources.rc files:

1.) chrome_unscaled_resources.rc. This is never linked to a chrome target (just
cs.chromium.org for "chrome_unscaled_resources.rc"), and it's loaded via
resources.pak on all platforms.

2.) ui_unscaled_resources.rc This contains windows cursors etc and is linked
into browser targets – which is why I'm not removing it from tests in this CL.

(Note that this CL only changes test targets, no production targets – and I'm
merely making the test targets look like the production targets.)

[Nico, 2014-01-07 20:05:57]

ping


On Tue, Jan 7, 2014 at 8:18 AM, <thakis@chromium.org> wrote:

> Thanks for the quick review!
>
> On 2014/01/06 23:40:28, oshima wrote:
>
>> +sail
>>
>
> sail is sadly no longer working on chrome.
>
>
>  My understanding is that unscaled resources should be loaded as rc files
>> on
>> Windows, although I may be wrong. sail should know for sure (or should
>> know
>>
> who
>
>> should know now).
>>
>
> There are two foo_unscaled_resources.rc files:
>
> 1.) chrome_unscaled_resources.rc. This is never linked to a chrome target
> (just
> cs.chromium.org for "chrome_unscaled_resources.rc"), and it's loaded via
> resources.pak on all platforms.
>
> 2.) ui_unscaled_resources.rc This contains windows cursors etc and is
> linked
> into browser targets – which is why I'm not removing it from tests in this
> CL.
>
> (Note that this CL only changes test targets, no production targets – and
> I'm
> merely making the test targets look like the production targets.)
>
> https://codereview.chromium.org/125103007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[oshima, 2014-01-07 23:52:54]

> 
> sail is sadly no longer working on chrome.

Yeah I know. I was hoping that he can just approve it, or tell us who should
review this.

I guess this change is correct, although I'm not 100% certain the current
situation (the fact that these resources are loaded from pak, not embedded) is
by design or a bug.

cpu@, maybe you can review this?

[cpu_(ooo_6.6-7.5), 2014-01-08 00:28:10]

lgtm

[commit-bot: I haz the power, 2014-01-08 00:35:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/125103007/40001

[commit-bot: I haz the power, 2014-01-08 03:15:18]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 03:48:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/125103007/40001

[commit-bot: I haz the power, 2014-01-08 06:35:42]

Change committed as 243503