Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 125103006: Delete char32 from base/basictypes.h. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
Reviewers:
brettw, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Delete char32 from base/basictypes.h. (Convert its one use to use int32_t instead.) R=brettw@chromium.org TBR=rsleevi@chromium.org BUG=138542 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243209

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 1

Patch Set 3 : foo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M base/basictypes.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M net/cert/x509_cert_types_mac.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 11 months ago (2014-01-06 20:40:40 UTC) #1
brettw
lgtm https://codereview.chromium.org/125103006/diff/30001/net/cert/x509_cert_types_mac.cc File net/cert/x509_cert_types_mac.cc (right): https://codereview.chromium.org/125103006/diff/30001/net/cert/x509_cert_types_mac.cc#newcode1 net/cert/x509_cert_types_mac.cc:1: // Copyright 2014 The Chromium Authors. All rights ...
6 years, 11 months ago (2014-01-06 20:42:18 UTC) #2
viettrungluu
On 2014/01/06 20:42:18, brettw wrote: > lgtm > > https://codereview.chromium.org/125103006/diff/30001/net/cert/x509_cert_types_mac.cc > File net/cert/x509_cert_types_mac.cc (right): > ...
6 years, 11 months ago (2014-01-06 21:18:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/125103006/100001
6 years, 11 months ago (2014-01-06 21:20:09 UTC) #4
viettrungluu
Committed patchset #3 manually as r243209 (presubmit successful).
6 years, 11 months ago (2014-01-06 23:58:52 UTC) #5
Ryan Sleevi
6 years, 11 months ago (2014-01-11 04:27:05 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698