Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2394)

Unified Diff: ash/system/tray/tray_background_view.h

Issue 12510005: Remove close_on_deactivate=false for tray bubbles (2nd) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/tray/system_tray.cc ('k') | ash/system/tray/tray_bubble_wrapper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/tray/tray_background_view.h
diff --git a/ash/system/tray/tray_background_view.h b/ash/system/tray/tray_background_view.h
index 8b13665566eab7d5b5374b583e3daeb0a33c0986..ebfe221c43e0fc111ddd6bc0b0609cac33f7459e 100644
--- a/ash/system/tray/tray_background_view.h
+++ b/ash/system/tray/tray_background_view.h
@@ -87,7 +87,8 @@ class ASH_EXPORT TrayBackgroundView : public ActionableView,
virtual string16 GetAccessibleNameForTray() = 0;
// Hides the bubble associated with |bubble_view|. Called when the widget
- // is closed.
+ // is closed. |bubble_view| may be already destroyed when it's called, so
+ // any methods are called to |bubble_view| without any checks.
jennyz 2013/03/06 18:04:04 Can you be clearer about "any methods are called t
Jun Mukai 2013/03/07 00:26:42 removed the sentence of 'any methods...', I don't
virtual void HideBubbleWithView(const views::TrayBubbleView* bubble_view) = 0;
// Called by the bubble wrapper when a click event occurs outside the bubble.
« no previous file with comments | « ash/system/tray/system_tray.cc ('k') | ash/system/tray/tray_bubble_wrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698