Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: base/test/BUILD.gn

Issue 1250913002: patch from chinmaygarde@ to make progress on mac, ios. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweaks needed to get base_unittests to compile Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/BUILD.gn
diff --git a/base/test/BUILD.gn b/base/test/BUILD.gn
index 127ec825d522a84467f6d4edf3d5f2341809f60d..a137bf60b314108279259c1d2420e0b51a9e8b7b 100644
--- a/base/test/BUILD.gn
+++ b/base/test/BUILD.gn
@@ -23,7 +23,7 @@ source_set("test_config") {
}
# GYP: //base/base.gyp:test_support_base
-source_set("test_support") {
+static_library("test_support") {
sdefresne 2015/07/25 19:15:29 Why the change from "source_set" to "static_librar
Dirk Pranke 2015/07/31 21:27:40 source_set is recommended, you're right. I had in
# TODO http://crbug.com/412064 enable this flag all the time.
testonly = !is_component_build
sources = [
@@ -154,6 +154,8 @@ source_set("test_support") {
# iOS uses its own unit test launcher.
sources -= [ "launcher/unit_test_launcher.cc" ]
+ sources -= [ "multiprocess_test.cc" ]
+
# Pull in specific Mac files for iOS (which have been filtered out
# by file name rules).
set_sources_assignment_filter([])

Powered by Google App Engine
This is Rietveld 408576698