Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4066)

Unified Diff: base/test/BUILD.gn

Issue 1250913002: patch from chinmaygarde@ to make progress on mac, ios. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: status Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/BUILD.gn
diff --git a/base/test/BUILD.gn b/base/test/BUILD.gn
index c36d2664b0d94f07d9c261b974f68e983b718e45..3239915aef82b48641dc2dc442aa38c26b3fa3b6 100644
--- a/base/test/BUILD.gn
+++ b/base/test/BUILD.gn
@@ -37,15 +37,11 @@ source_set("test_support") {
"histogram_tester.h",
"ios/wait_util.h",
"ios/wait_util.mm",
- "launcher/test_launcher.cc",
"launcher/test_launcher.h",
"launcher/test_result.cc",
"launcher/test_result.h",
- "launcher/test_results_tracker.cc",
"launcher/test_results_tracker.h",
- "launcher/unit_test_launcher.cc",
"launcher/unit_test_launcher.h",
- "launcher/unit_test_launcher_ios.cc",
"mock_chrome_application_mac.h",
"mock_chrome_application_mac.mm",
"mock_devices_changed_observer.cc",
@@ -54,9 +50,7 @@ source_set("test_support") {
"mock_entropy_provider.h",
"mock_log.cc",
"mock_log.h",
- "multiprocess_test.cc",
"multiprocess_test.h",
- "multiprocess_test_android.cc",
"null_task_runner.cc",
"null_task_runner.h",
"opaque_ref_counted.cc",
@@ -126,6 +120,18 @@ source_set("test_support") {
"values_test_util.h",
]
+ if (is_ios) {
+ sources += [ "launcher/unit_test_launcher_ios.cc" ]
+ } else {
+ sources += [
+ "launcher/test_launcher.cc",
+ "launcher/test_results_tracker.cc",
+ "launcher/unit_test_launcher.cc",
+ "multiprocess_test.cc",
+ "multiprocess_test_android.cc",
+ ]
+ }
+
configs += [ "//build/config:precompiled_headers" ]
data = [
@@ -154,14 +160,11 @@ source_set("test_support") {
"scoped_locale.h",
]
}
- if (is_ios) {
- # iOS uses its own unit test launcher.
- sources -= [ "launcher/unit_test_launcher.cc" ]
- # Pull in specific Mac files for iOS (which have been filtered out
- # by file name rules).
+ if (is_ios) {
set_sources_assignment_filter([])
sources += [ "test_file_util_mac.cc" ]
+ set_sources_assignment_filter(sources_assignment_filter)
}
if (is_android) {
« base/BUILD.gn ('K') | « base/process/BUILD.gn ('k') | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698