Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: BUILD.gn

Issue 1250913002: patch from chinmaygarde@ to make progress on mac, ios. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: status Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | base/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 9268fef2d85246c3ed74610706f2ed206aa238e4..a05b4ccbb1e77c5c85b4cacaf92d01a6c29c8984 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -65,9 +65,11 @@ group("both_gn_and_gyp") {
testonly = true
deps = [
"//base:base_unittests",
- "//sync:sync_unit_tests",
]
+
if (!is_ios) {
+ # TODO(GYP): Figure out which of these should actually build on iOS,
+ # and whether there should be other targets that are iOS-only and missing.
deps += [
"//cc:cc_unittests",
"//chrome",
@@ -134,6 +136,7 @@ group("both_gn_and_gyp") {
"//printing:printing_unittests",
"//skia:skia_unittests",
"//sql:sql_unittests",
+ "//sync:sync_unit_tests",
"//third_party/WebKit/Source/platform:heap_unittests",
"//third_party/WebKit/Source/platform:platform_unittests",
"//third_party/WebKit/Source/web:webkit_unit_tests",
@@ -599,10 +602,10 @@ group("both_gn_and_gyp") {
group("gn_only") {
testonly = true
+ deps = []
+
if (!is_ios) {
- deps = [
- "//mandoline:all",
- ]
+ deps += [ "//mandoline:all" ]
}
if (!is_android && !is_ios) {
« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | base/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698