Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1969)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1250913002: patch from chinmaygarde@ to make progress on mac, ios. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge to #341416 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 9120e66e9d9ad6023ad37cf7670d7d95fef382b2..ac5dd23232743d8e6a9d5cc8944fa873946c1b97 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -270,9 +270,12 @@ config("compiler") {
"i386",
]
} else if (current_cpu == "arm") {
+ # TODO(GYP): we may need to distinguish between "arm64", "armv7",
+ # and "armv7s" for iOS, and hence need multiple current_cpu values
+ # rather than just "arm".
common_mac_flags += [
"-arch",
- "armv7",
+ "arm64",
]
}

Powered by Google App Engine
This is Rietveld 408576698