patch from chinmaygarde@ to make progress on mac, ios.

build/config/ios/ios_sdk.gni

-# Copyright 2014 The Chromium Authors. All rights reserved.
+# Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 declare_args() {
   # SDK path to use. When empty this will use the default SDK based on the
   # value of use_ios_simulator.
   ios_sdk_path = ""
 
   # Set to true when targeting a simulator build on iOS. False means that the
   # target is for running on the device. The default value is to use the
   # Simulator except when targeting GYP's Xcode builds (for compat with the
   # existing GYP build).
   use_ios_simulator = true

[sdefresne, 2015/07/25 19:15:30]

nit: since gyp always generate the four possible combination of {device,
simulator} x {release, debug}, I think the comment is misleading. IMO, I think
we should have "use_ios_simulator = (target_cpu == "x86" || target_cpu ==
"x64")" since only the simulator supports Intel opcode and only devices supports
ARM opcode.

[Dirk Pranke, 2015/07/31 21:27:40]

Agreed. Good suggestion.

 
   # Version of iOS that we're targeting.
   ios_deployment_target = "6.0"

[sdefresne, 2015/07/25 19:15:30]

nit: gyp uses "7.0" as the default ios_deployment_target (see build/common.gypi)
so I think we should update this one too.

[Dirk Pranke, 2015/07/31 21:27:40]

Done.

+
+  # The iOS Code signing identity to use
+  ios_code_signing_identity = ""
 }

[sdefresne, 2015/07/25 19:15:30]

We need to provide a way to build for "armv7"/"arm64" (i.e. for devices) without
signing for two uses case, 1. for upstream bots, as they do not have a valid key
to sign, and 2. for downstream release build as the signature is done in a
second step.

I would recommend doing:

# Control whether code signing is enabled. Only used when building for real
devices
# in order to allow signing in a later stage.
ios_enable_code_signing = true

[Dirk Pranke, 2015/07/31 21:27:40]

Will rework.

 
 if (ios_sdk_path == "") {
   # Compute default target.
   if (use_ios_simulator) {
     _ios_sdk_to_query = "iphonesimulator"
   } else {
     _ios_sdk_to_query = "iphoneos"
   }
   _ios_sdk_result =
       exec_script("ios_sdk.py", [ _ios_sdk_to_query ], "list lines")
   ios_sdk_path = _ios_sdk_result[0]
 }
+
+if (use_ios_simulator) {

[sdefresne, 2015/07/25 19:15:30]

Change to

if (use_ios_simulator || !ios_enabled_code_signin) {

[Dirk Pranke, 2015/07/31 21:27:40]

Will rework.

+  # Always disable code signing on the simulator
+  ios_code_signing_identity = ""
+} else {
+  # If an identity is not provided, look for one on the host
+  if (ios_code_signing_identity == "") {
+    _ios_identities = exec_script("find_signing_identity.py", [], "list lines")
+    ios_code_signing_identity = _ios_identities[0]
+  }
+
+  if (ios_code_signing_identity == "") {
+    print("Tried to prepare a device build without specifying a code signing")
+    print("identity and could not detect one automatically either.")
+    print("TIP: Simulator builds dont require code signing...")
+    assert(false)
+  }
+}