Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1250913002: patch from chinmaygarde@ to make progress on mac, ios. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweaks needed to get base_unittests to compile Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 if (current_cpu == "x64") { 259 if (current_cpu == "x64") {
260 common_mac_flags += [ 260 common_mac_flags += [
261 "-arch", 261 "-arch",
262 "x86_64", 262 "x86_64",
263 ] 263 ]
264 } else if (current_cpu == "x86") { 264 } else if (current_cpu == "x86") {
265 common_mac_flags += [ 265 common_mac_flags += [
266 "-arch", 266 "-arch",
267 "i386", 267 "i386",
268 ] 268 ]
269 } else if (current_cpu == "arm") { 269 } else if (current_cpu == "arm") {
sdefresne 2015/07/25 19:15:29 I think we should add support for "armv7" and "arm
Dirk Pranke 2015/07/31 21:27:40 This seems reasonable but well out of the scope of
270 common_mac_flags += [ 270 common_mac_flags += [
271 "-arch", 271 "-arch",
272 "armv7", 272 "arm64",
273 ] 273 ]
274 } 274 }
275 275
276 cflags += common_mac_flags 276 cflags += common_mac_flags
277 277
278 # Without this, the constructors and destructors of a C++ object inside 278 # Without this, the constructors and destructors of a C++ object inside
279 # an Objective C struct won't be called, which is very bad. 279 # an Objective C struct won't be called, which is very bad.
280 cflags_objcc += [ "-fobjc-call-cxx-cdtors" ] 280 cflags_objcc += [ "-fobjc-call-cxx-cdtors" ]
281 281
282 cflags_c += [ "-std=c99" ] 282 cflags_c += [ "-std=c99" ]
(...skipping 981 matching lines...) Expand 10 before | Expand all | Expand 10 after
1264 cflags += [ "-gsplit-dwarf" ] 1264 cflags += [ "-gsplit-dwarf" ]
1265 } 1265 }
1266 } 1266 }
1267 } 1267 }
1268 1268
1269 config("no_symbols") { 1269 config("no_symbols") {
1270 if (!is_win) { 1270 if (!is_win) {
1271 cflags = [ "-g0" ] 1271 cflags = [ "-g0" ]
1272 } 1272 }
1273 } 1273 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698