Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1250883002: Count data deps even if it was already a regular dep (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Count data deps even if it was already a regular dep Previously GN's runtime deps computation would only count a target once, but this ignores the fact that whether a target is a data dependency or a regular one affects how it's added. This patch revisits a target if it's depended on in a data dependency even if it's already been seen as a regular dependency. Enhance the runtime deps documentation. Committed: https://crrev.com/295e07207149d215f749dffb68c9c56e1188bc4d Cr-Commit-Position: refs/heads/master@{#339778}

Patch Set 1 #

Total comments: 1

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -8 lines) Patch
M tools/gn/runtime_deps.cc View 1 5 chunks +52 lines, -8 lines 0 comments Download
M tools/gn/runtime_deps_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
brettw
5 years, 5 months ago (2015-07-21 22:30:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250883002/1
5 years, 5 months ago (2015-07-21 22:31:09 UTC) #4
Dirk Pranke
lgtm w/ typo fixed. https://codereview.chromium.org/1250883002/diff/1/tools/gn/runtime_deps.cc File tools/gn/runtime_deps.cc (right): https://codereview.chromium.org/1250883002/diff/1/tools/gn/runtime_deps.cc#newcode175 tools/gn/runtime_deps.cc:175: " build's paralellism would be ...
5 years, 5 months ago (2015-07-21 23:00:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-21 23:02:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250883002/20001
5 years, 5 months ago (2015-07-21 23:05:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 23:31:17 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 23:32:22 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/295e07207149d215f749dffb68c9c56e1188bc4d
Cr-Commit-Position: refs/heads/master@{#339778}

Powered by Google App Engine
This is Rietveld 408576698