chrome/BUILD.gn - Issue 1250853007: Hook up chrome.exe manifest in the Windows GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1250853007: Hook up chrome.exe manifest in the Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 9972fdb071693aa27e8707571f65b8fbfe422410..dbbd2a04098a76e7596c6cae4d1ff77d58bcaf48 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -71,6 +71,7 @@ if (!is_android) {

"//base",

"//breakpad:breakpad_handler",

"//breakpad:breakpad_sender",

+ "//chrome/app/version_assembly:chrome_exe_manifest",

"//chrome/browser:chrome_process_finder",

"//chrome/chrome_watcher",

"//chrome/chrome_watcher:client",

@@ -83,6 +84,8 @@ if (!is_android) {

"//sandbox",

"//ui/gfx",

]

+ data_deps = [ "//chrome/app/version_assembly:version_assembly_manifest" ]

libs = [

"wintrust.lib",

"crypt32.lib",

« no previous file with comments | « build/util/version.gni ('k') | chrome/app/version_assembly/BUILD.gn » ('j') | no next file with comments »