Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1250853007: Hook up chrome.exe manifest in the Windows GN build. (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, chromoting-reviews_chromium.org, gab+watch_chromium.org, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up chrome.exe manifest in the Windows GN build. This generates a proper version manifest for chrome.exe and also for the version assembly. This adds a new way to get the chrome version info programatically at GN time. Although this adds another exec_script call, it removes four such calls in remoting so there is a net speed increase. BUG= Committed: https://crrev.com/983c0562bba1e4d93bb7ee489f56bcbd61fc55f9 Cr-Commit-Position: refs/heads/master@{#339833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -60 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
A build/util/version.gni View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/app/version_assembly/BUILD.gn View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/version.gni View 3 chunks +33 lines, -10 lines 0 comments Download
M remoting/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/remoting_version.gni View 2 chunks +0 lines, -46 lines 0 comments Download
M remoting/webapp/build_template.gni View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 5 months ago (2015-07-21 23:57:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250853007/1
5 years, 5 months ago (2015-07-21 23:58:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-22 01:04:21 UTC) #6
Dirk Pranke
lgtm. /noideadog
5 years, 5 months ago (2015-07-22 01:13:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250853007/1
5 years, 5 months ago (2015-07-22 04:22:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 04:26:57 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 04:27:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/983c0562bba1e4d93bb7ee489f56bcbd61fc55f9
Cr-Commit-Position: refs/heads/master@{#339833}

Powered by Google App Engine
This is Rietveld 408576698