Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1250853002: Revert of Remove old/unused atomicops code (Closed)

Created:
5 years, 5 months ago by jdduke (slow)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove old/unused atomicops code (patchset #7 id:140001 of https://codereview.chromium.org/1211903003/) Reason for revert: Temporarily reverting until libc++ ships to stable on Android. Original issue's description: > Remove old/unused atomicops code > > None of these gcc versions of atomicopts are used in > chromium anymore. The portable versions were added in: > https://codereview.chromium.org/636783002 and all our > GCC-based targets use those now. > > This change mostly just removes dead code. > > Some files were added to base/allocator/BUILD.gn in order > to have it match allocator.gyp. These were not required > before but are now (specifically tcmalloc's > base/atomicops-internals-x86.cc). We got away without it > previously since base/atomicops_internals_x86_gcc.cc > provided the same symbol, but the symbol collision was > arguably a bug. > > BUG=423074 > > Committed: https://crrev.com/b030801fcf447602931b3e4b8f94aae8053c61fb > Cr-Commit-Position: refs/heads/master@{#337123} TBR=jfb@chromium.org,rmcilroy@chromium.org,danalbert@google.com,thakis@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=423074, 487341, 427718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1379 lines, -11 lines) Patch
M base/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M base/allocator/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M base/atomicops.h View 2 chunks +38 lines, -0 lines 0 comments Download
A base/atomicops_internals_arm64_gcc.h View 1 chunk +307 lines, -0 lines 0 comments Download
A base/atomicops_internals_arm_gcc.h View 1 chunk +294 lines, -0 lines 0 comments Download
A base/atomicops_internals_gcc.h View 1 chunk +106 lines, -0 lines 0 comments Download
A base/atomicops_internals_mips_gcc.h View 1 chunk +280 lines, -0 lines 0 comments Download
A base/atomicops_internals_x86_gcc.h View 1 chunk +228 lines, -0 lines 0 comments Download
A base/atomicops_internals_x86_gcc.cc View 1 chunk +103 lines, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
M base/base.gypi View 3 chunks +7 lines, -0 lines 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jdduke (slow)
Created Revert of Remove old/unused atomicops code
5 years, 5 months ago (2015-07-21 21:11:18 UTC) #1
jdduke (slow)
Preparing this revert should we need it to get M45 beta working on x86_64.
5 years, 5 months ago (2015-07-21 21:15:44 UTC) #2
JF
Could you clarify which version of libc++ is broken and how? It would be good ...
5 years, 5 months ago (2015-07-21 21:20:16 UTC) #3
jdduke (slow)
5 years, 5 months ago (2015-07-21 21:24:45 UTC) #4
On 2015/07/21 21:20:16, JF wrote:
> Could you clarify which version of libc++ is broken and how? It would be good
to
> know when this patch can be reapplied.

See crbug.com/487341 for details. In particular, we're finding that there are
some rendering issues with x86_64 builds on Intel GPUs. We still don't know what
exactly is broken, let alone why or whether the "fault" lies with us or their
driver.

Powered by Google App Engine
This is Rietveld 408576698