Issue 125085: Fix ambiguous method errors by explicitly passing reloc info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125085: Fix ambiguous method errors by explicitly passing reloc info. (Closed)

Created:
11 years, 6 months ago by Benno

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix ambiguous method errors by explicitly passing reloc info. BUG=377

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -32 lines)			Patch
M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/builtins-arm.cc	View	1 2	5 chunks	+6 lines, -5 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1	18 chunks	+25 lines, -23 lines	1 comment	Download
M	src/arm/debug-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 6 months ago (2009-06-15 08:59:29 UTC) #1

LGTM.

http://codereview.chromium.org/125085/diff/1016/1020
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/125085/diff/1016/1020#newcode3574
Line 3574: // not counting receiver
// Argument count does not include the receiver.
Comments should be grammatical sentences.  Since you are
moving the comment anyway, let's fix it.

Expand Messages | Collapse Messages