Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/PictureRenderingFlags.cpp

Issue 125083004: Support mesa config in render_pictures. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Initial upload Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/PictureRenderer.h ('K') | « tools/PictureRenderer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/PictureRenderingFlags.cpp
===================================================================
--- tools/PictureRenderingFlags.cpp (revision 12907)
+++ tools/PictureRenderingFlags.cpp (working copy)
@@ -28,6 +28,8 @@
#if SK_ANGLE
// ANGLE assumes GPU
DEFINE_string(config, "8888", "[8888|gpu|msaa4|msaa16|angle]: Use the corresponding config.");
robertphillips 2014/01/06 15:57:59 What if we have both angle and mesa defined?
epoger 2014/01/06 16:01:47 Right. I guess we need something like this: SkSt
rmistry 2014/01/06 18:03:55 Done with something similar to the above suggestio
+#elif SK_MESA
+DEFINE_string(config, "8888", "[8888|gpu|msaa4|msaa16|mesa]: Use the corresponding config.");
#elif SK_SUPPORT_GPU
DEFINE_string(config, "8888", "[8888|gpu|msaa4|msaa16]: Use the corresponding config.");
#else
@@ -285,7 +287,16 @@
}
}
#endif
+#if SK_MESA
+ else if (0 == strcmp(FLAGS_config[0], "mesa")) {
+ deviceType = sk_tools::PictureRenderer::kMesa_DeviceType;
+ if (FLAGS_multi > 1) {
+ error.printf("Mesa not compatible with multithreaded tiling.\n");
+ return NULL;
+ }
+ }
#endif
+#endif
else {
error.printf("%s is not a valid mode for --config\n", FLAGS_config[0]);
return NULL;
« tools/PictureRenderer.h ('K') | « tools/PictureRenderer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698