Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1250803003: CFI: blacklist the types from std:: to get rid of false positives. (Closed)

Created:
5 years, 5 months ago by krasin
Modified:
5 years, 5 months ago
Reviewers:
Nico, pcc1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CFI: blacklist the types from std:: to get rid of false positives. The problem is that CFI requires static linking to resolve all the types and their vtables, but libstc++ are loaded dynamically. Potentially, it could be eliminated by using statically linked libc++. BUG=chromium:457523, chromium:512553 Committed: https://crrev.com/3ec79cc8547b36a1e02a1e8f269d89e08d1e7852 Cr-Commit-Position: refs/heads/master@{#339970}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 3 chunks +21 lines, -0 lines 0 comments Download
M tools/cfi/blacklist.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
krasin
5 years, 5 months ago (2015-07-21 21:53:34 UTC) #2
pcc1
https://codereview.chromium.org/1250803003/diff/1/tools/cfi/blacklist.txt File tools/cfi/blacklist.txt (right): https://codereview.chromium.org/1250803003/diff/1/tools/cfi/blacklist.txt#newcode26 tools/cfi/blacklist.txt:26: # getting better. It isn't clear what you mean ...
5 years, 5 months ago (2015-07-22 11:06:12 UTC) #3
krasin
Please, take another look. https://codereview.chromium.org/1250803003/diff/1/tools/cfi/blacklist.txt File tools/cfi/blacklist.txt (right): https://codereview.chromium.org/1250803003/diff/1/tools/cfi/blacklist.txt#newcode26 tools/cfi/blacklist.txt:26: # getting better. On 2015/07/22 ...
5 years, 5 months ago (2015-07-22 18:15:35 UTC) #4
pcc1
On 2015/07/22 18:15:35, krasin wrote: > Please, take another look. > > https://codereview.chromium.org/1250803003/diff/1/tools/cfi/blacklist.txt > File ...
5 years, 5 months ago (2015-07-22 18:19:49 UTC) #5
krasin
On 2015/07/22 18:19:49, pcc1 wrote: > On 2015/07/22 18:15:35, krasin wrote: > > Please, take ...
5 years, 5 months ago (2015-07-22 18:20:27 UTC) #6
krasin
5 years, 5 months ago (2015-07-22 18:20:43 UTC) #8
Nico
Lgtm Msan builds against libc++, so setting that up is probably not super hard.
5 years, 5 months ago (2015-07-22 19:33:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250803003/20001
5 years, 5 months ago (2015-07-22 20:26:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/81539)
5 years, 5 months ago (2015-07-22 21:42:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250803003/20001
5 years, 5 months ago (2015-07-22 21:45:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 23:06:03 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 23:06:54 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ec79cc8547b36a1e02a1e8f269d89e08d1e7852
Cr-Commit-Position: refs/heads/master@{#339970}

Powered by Google App Engine
This is Rietveld 408576698