Enabling testing Google Now component extension

chrome/browser/resources/google_now/background.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview The event page for Google Now for Chrome implementation.
  * The Google Now event page gets Google Now cards from the server and shows
  * them as Chrome notifications.
  * The service performs periodic updating of Google Now cards.
  * Each updating of the cards includes 3 steps:
  * 1. Obtaining the location of the machine;
  * 2. Making a server request based on that location;
  * 3. Showing the received cards as notifications.
  */
 
 // TODO(vadimt): Use background permission to show notifications even when all
 // browser windows are closed.
 // TODO(vadimt): Remove the C++ implementation.
 // TODO(vadimt): Decide what to do in incognito mode.
 // TODO(vadimt): Gather UMAs.
 // TODO(vadimt): Honor the flag the enables Google Now integration.
 // TODO(vadimt): Figure out the final values of the constants.
 // TODO(vadimt): Report internal and server errors. Collect UMAs on errors where
 // appropriate. Also consider logging errors or throwing exceptions.
 
+// TODO(vadimt): Consider processing errors for all storage.set calls.

[skare_, 2013/03/06 22:08:01]

has this edit already been done in another review or am I experiencing deja vu?

[vadimt, 2013/03/06 22:37:12]

"Yes" to both :)
The Races review (next in the queue) moves a newline AFAIR.

[skare_, 2013/03/07 00:56:39]

ok, great, thanks
On 2013/03/06 22:37:12, vadimt wrote:

 // TODO(vadimt): Figure out the server name. Use it in the manifest and for
-// TODO(vadimt): Consider processing errors for all storage.set calls.
 // NOTIFICATION_CARDS_URL. Meanwhile, to use the feature, you need to manually
-// edit NOTIFICATION_CARDS_URL before building Chrome.
+// set the server name via local storage.
 /**
  * URL to retrieve notification cards.
  */
-var NOTIFICATION_CARDS_URL = '';
+var NOTIFICATION_CARDS_URL = localStorage['server_url'];
 
 /**
  * Standard response code for successful HTTP requests. This is the only success
  * code the server will send.
  */
 var HTTP_OK = 200;
 
 /**
  * Initial period for polling for Google Now Notifications cards to use when the
  * period from the server is not available.
@@ skipping 55 matching lines @@
     // Mark existing notifications that received an update in this server
     // response.
     for (var i = 0; i < cards.length; ++i) {
       var notificationId = cards[i].notificationId;
       if (notificationId in items.activeNotifications)
         items.activeNotifications[notificationId].hasUpdate = true;
     }
 
     // Delete notifications that didn't receive an update.
     for (var notificationId in items.activeNotifications)
-      if (!items.activeNotifications[notificationId].hasUpdate) {
+      if (items.activeNotifications.hasOwnProperty(notificationId) &&
+          !items.activeNotifications[notificationId].hasUpdate) {
         chrome.experimental.notification.clear(
             notificationId,
             function(wasDeleted) {});
     }
 
     // Create/update notifications and store their new properties.
     var notificationsUrlInfo = {};
 
     for (var i = 0; i < cards.length; ++i) {
       try {
@@ skipping 178 matching lines @@
     function(notificationId, buttonIndex) {
       onNotificationClicked(notificationId, function(actionUrls) {
         if (!Array.isArray(actionUrls.buttonUrls))
           return undefined;
 
         return actionUrls.buttonUrls[buttonIndex];
       });
     });
 
 chrome.experimental.notification.onClosed.addListener(onNotificationClosed);