Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1250793008: Webfont fetch should be CORS-enabled even for same-origin URL (Closed)

Created:
5 years, 5 months ago by Kunihiko Sakamoto
Modified:
5 years, 5 months ago
Reviewers:
Mike West, bashi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, horo, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Webfont fetch should be CORS-enabled even for same-origin URL Before this patch, webfont request was made with no-cors mode when the URL of font face was same-origin. However, that same-origin request may be redirected to another origin. This patch makes webfont requests use cors mode for (initially) same-origin requests too, in order to let ResourceFetcher handle same/cross origin stuff. (This matches how <img crossorigin> works.) BUG=512678 TEST=http/tests/webfont/webfont-cors.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199364

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M LayoutTests/http/tests/serviceworker/fetch-request-resources.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/webfont/webfont-cors.html View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/webfont/webfont-cors-expected.html View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Kunihiko Sakamoto
5 years, 5 months ago (2015-07-23 07:07:11 UTC) #2
Mike West
Shouldn't there be a PNG for this layout test?
5 years, 5 months ago (2015-07-23 07:29:34 UTC) #3
Kunihiko Sakamoto
On 2015/07/23 07:29:34, Mike West wrote: > Shouldn't there be a PNG for this layout ...
5 years, 5 months ago (2015-07-23 07:35:15 UTC) #4
Mike West
Got it. I misunderstood the tests, thanks for the clarification! :) LGTM.
5 years, 5 months ago (2015-07-23 07:59:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250793008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250793008/40001
5 years, 5 months ago (2015-07-23 09:17:07 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199364
5 years, 5 months ago (2015-07-23 09:20:28 UTC) #8
bashi
On 2015/07/23 09:20:28, commit-bot: I haz the power wrote: > Committed patchset #3 (id:40001) as ...
5 years, 5 months ago (2015-07-23 23:33:04 UTC) #9
Kunihiko Sakamoto
On 2015/07/23 23:33:04, bashi1 wrote: > On 2015/07/23 09:20:28, commit-bot: I haz the power wrote: ...
5 years, 5 months ago (2015-07-24 02:00:10 UTC) #10
bashi
5 years, 5 months ago (2015-07-24 02:01:17 UTC) #11
Message was sent while issue was closed.
On 2015/07/24 02:00:10, Kunihiko Sakamoto wrote:
> On 2015/07/23 23:33:04, bashi1 wrote:
> > On 2015/07/23 09:20:28, commit-bot: I haz the power wrote:
> > > Committed patchset #3 (id:40001) as
> > > https://src.chromium.org/viewvc/blink?view=rev&revision=199364
> > 
> > Sorry for the delayed comment but does this change align other browsers
> > behavior?
> 
> Verified that Firefox also rejects 'redirectCorsNG' in webfont-cors.html.
> 
> This behavior is speced in HTML Standard as "potentially CORS-enabled fetch".
> https://html.spec.whatwg.org/multipage/infrastructure.html#cors-enabled-fetch

Thanks for the confirmation. LGTM:)

Powered by Google App Engine
This is Rietveld 408576698