Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: src/x64/code-stubs-x64.cc

Issue 1250733005: SIMD.js Add the other SIMD Phase 1 types. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/x64/code-stubs-x64.cc
diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc
index 7d717015ab15eafca2e406bcd00bbe0aeded2864..46da56e90d4479fe75684e0a755bb732751e60c6 100644
--- a/src/x64/code-stubs-x64.cc
+++ b/src/x64/code-stubs-x64.cc
@@ -1565,6 +1565,7 @@ void CompareICStub::GenerateGeneric(MacroAssembler* masm) {
factory->heap_number_map());
__ j(equal, &heap_number, Label::kNear);
if (cc != equal) {
+ Label not_simd;
__ movp(rcx, FieldOperand(rax, HeapObject::kMapOffset));
__ movzxbl(rcx, FieldOperand(rcx, Map::kInstanceTypeOffset));
// Call runtime on identical objects. Otherwise return equal.
@@ -1574,8 +1575,11 @@ void CompareICStub::GenerateGeneric(MacroAssembler* masm) {
__ cmpb(rcx, Immediate(static_cast<uint8_t>(SYMBOL_TYPE)));
__ j(equal, &runtime_call, Label::kFar);
// Call runtime on identical SIMD values since we must throw a TypeError.
- __ cmpb(rcx, Immediate(static_cast<uint8_t>(FLOAT32X4_TYPE)));
- __ j(equal, &runtime_call, Label::kFar);
+ __ cmpb(rcx, Immediate(static_cast<uint8_t>(FIRST_SIMD128_VALUE_TYPE)));
+ __ j(less, &not_simd, Label::kFar);
+ __ cmpb(rcx, Immediate(static_cast<uint8_t>(LAST_SIMD128_VALUE_TYPE)));
+ __ j(less_equal, &runtime_call, Label::kFar);
+ __ bind(&not_simd);
if (is_strong(strength())) {
// We have already tested for smis and heap numbers, so if both
// arguments are not strings we must proceed to the slow case.
« src/runtime/runtime-simd.cc ('K') | « src/utils.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698