src/code-stubs.cc - Issue 1250733005: SIMD.js Add the other SIMD Phase 1 types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs.cc

Issue 1250733005: SIMD.js Add the other SIMD Phase 1 types. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/code-stubs.cc

diff --git a/src/code-stubs.cc b/src/code-stubs.cc

index ee57db741e3714ef45c5fb913c17b1f5a2461126..b8e792742f62749b4fe705a69cb1d7115cfbf7ab 100644

--- a/src/code-stubs.cc

+++ b/src/code-stubs.cc

@@ -989,7 +989,7 @@ bool ToBooleanStub::Types::UpdateStatus(Handle<Object> object) {

Add(HEAP_NUMBER);

double value = HeapNumber::cast(*object)->value();

return value != 0 && !std::isnan(value);

- } else if (object->IsFloat32x4()) {

+ } else if (object->IsSimd128Value()) {

Add(SIMD_VALUE);

return true;

} else {