Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: src/x87/code-stubs-x87.cc

Issue 1250733005: SIMD.js Add the other SIMD Phase 1 types. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/x87/code-stubs-x87.cc
diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc
index e70f9c85b962b73d5122ee43b4102fb6804c9bbd..2a67225ba71e831aa7c01a63375dd24362deac71 100644
--- a/src/x87/code-stubs-x87.cc
+++ b/src/x87/code-stubs-x87.cc
@@ -1389,6 +1389,7 @@ void CompareICStub::GenerateGeneric(MacroAssembler* masm) {
Immediate(isolate()->factory()->heap_number_map()));
__ j(equal, &generic_heap_number_comparison, Label::kNear);
if (cc != equal) {
+ Label not_simd;
__ mov(ecx, FieldOperand(eax, HeapObject::kMapOffset));
__ movzx_b(ecx, FieldOperand(ecx, Map::kInstanceTypeOffset));
// Call runtime on identical JSObjects. Otherwise return equal.
@@ -1398,8 +1399,11 @@ void CompareICStub::GenerateGeneric(MacroAssembler* masm) {
__ cmpb(ecx, static_cast<uint8_t>(SYMBOL_TYPE));
__ j(equal, &runtime_call, Label::kFar);
// Call runtime on identical SIMD values since we must throw a TypeError.
- __ cmpb(ecx, static_cast<uint8_t>(FLOAT32X4_TYPE));
- __ j(equal, &runtime_call, Label::kFar);
+ __ cmpb(ecx, static_cast<uint8_t>(FIRST_SIMD128_VALUE_TYPE));
+ __ j(less, &not_simd, Label::kFar);
+ __ cmpb(ecx, static_cast<uint8_t>(LAST_SIMD128_VALUE_TYPE));
+ __ j(less_equal, &runtime_call, Label::kFar);
+ __ bind(&not_simd);
if (is_strong(strength())) {
// We have already tested for smis and heap numbers, so if both
// arguments are not strings we must proceed to the slow case.

Powered by Google App Engine
This is Rietveld 408576698