SIMD.js Add the other SIMD Phase 1 types.

src/runtime.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This files contains runtime support implemented in JavaScript.
 
 // CAUTION: Some of the functions specified in this file are called
 // directly from compiled code. These are the functions with names in
 // ALL CAPS. The compiled code passes the first argument in 'this'.
 
@@ skipping 85 matching lines @@
 // ECMA-262 Section 11.9.3.
 EQUALS = function EQUALS(y) {
   if (IS_STRING(this) && IS_STRING(y)) return %StringEquals(this, y);
   var x = this;
 
   while (true) {
     if (IS_NUMBER(x)) {
       while (true) {
         if (IS_NUMBER(y)) return %NumberEquals(x, y);
         if (IS_NULL_OR_UNDEFINED(y)) return 1;  // not equal
-        if (IS_SYMBOL(y) || IS_FLOAT32X4(y)) return 1;  // not equal
+        if (IS_SYMBOL(y) || IS_SIMD_VALUE(y)) return 1;  // not equal

[bbudge, 2015/07/30 13:46:58]

I moved these primitive checks which always return "not equal" to the end of
their blocks, since they shouldn't be encountered in real or benchmark code. 
WDYT?

[rossberg, 2015/07/30 15:12:24]

Fine with me.

         if (!IS_SPEC_OBJECT(y)) {
           // String or boolean.
           return %NumberEquals(x, %$toNumber(y));
         }
         y = %$toPrimitive(y, NO_HINT);
       }
     } else if (IS_STRING(x)) {
       while (true) {
         if (IS_STRING(y)) return %StringEquals(x, y);
-        if (IS_SYMBOL(y) || IS_FLOAT32X4(y)) return 1;  // not equal
+        if (IS_SYMBOL(y) || IS_SIMD_VALUE(y)) return 1;  // not equal

[bbudge, 2015/07/30 13:46:58]

Made this %IsSimdValue call and moved it to the end of this block with the
IS_SYMBOL case.

         if (IS_NUMBER(y)) return %NumberEquals(%$toNumber(x), y);
         if (IS_BOOLEAN(y)) return %NumberEquals(%$toNumber(x), %$toNumber(y));
         if (IS_NULL_OR_UNDEFINED(y)) return 1;  // not equal
         y = %$toPrimitive(y, NO_HINT);
       }
     } else if (IS_SYMBOL(x)) {
       if (IS_SYMBOL(y)) return %_ObjectEquals(x, y) ? 0 : 1;
       return 1; // not equal
     } else if (IS_BOOLEAN(x)) {
       if (IS_BOOLEAN(y)) return %_ObjectEquals(x, y) ? 0 : 1;
       if (IS_NULL_OR_UNDEFINED(y)) return 1;
       if (IS_NUMBER(y)) return %NumberEquals(%$toNumber(x), y);
       if (IS_STRING(y)) return %NumberEquals(%$toNumber(x), %$toNumber(y));
-      if (IS_SYMBOL(y) || IS_FLOAT32X4(y)) return 1;  // not equal
+      if (IS_SYMBOL(y) || IS_SIMD_VALUE(y)) return 1;  // not equal
       // y is object.
       x = %$toNumber(x);
       y = %$toPrimitive(y, NO_HINT);
     } else if (IS_NULL_OR_UNDEFINED(x)) {
       return IS_NULL_OR_UNDEFINED(y) ? 0 : 1;
     } else if (IS_FLOAT32X4(x)) {

[rossberg, 2015/07/29 14:37:55]

Guard these by a (cheaper) IS_SIMD_VALUE test.

[bbudge, 2015/07/30 13:46:58]

Done. Using %IsSimdValue intrinsic. Also, moved all the type checking into a
SimdEquals intrinsic.

       if (IS_FLOAT32X4(y))
         return %Float32x4Equals(x, y);
       return 1;  // not equal
+    } else if (IS_INT32X4(x)) {
+      if (IS_INT32X4(y))
+        return %Int32x4Equals(x, y);
+      return 1;  // not equal
+    } else if (IS_BOOL32X4(x)) {
+      if (IS_BOOL32X4(y))
+        return %Bool32x4Equals(x, y);
+      return 1;  // not equal
+    } else if (IS_INT16X8(x)) {
+      if (IS_INT16X8(y))
+        return %Int16x8Equals(x, y);
+      return 1;  // not equal
+    } else if (IS_BOOL16X8(x)) {
+      if (IS_BOOL16X8(y))
+        return %Bool16x8Equals(x, y);
+      return 1;  // not equal
+    } else if (IS_INT8X16(x)) {
+      if (IS_INT8X16(y))
+        return %Int8x16Equals(x, y);
+      return 1;  // not equal
+    } else if (IS_BOOL8X16(x)) {
+      if (IS_BOOL8X16(y))
+        return %Bool8x16Equals(x, y);
+      return 1;  // not equal
     } else {
       // x is an object.
       if (IS_SPEC_OBJECT(y)) {
         return %_ObjectEquals(x, y) ? 0 : 1;
       }
       if (IS_NULL_OR_UNDEFINED(y)) return 1;  // not equal
-      if (IS_SYMBOL(y) || IS_FLOAT32X4(y)) return 1;  // not equal
+      if (IS_SYMBOL(y) || IS_SIMD_VALUE(y)) return 1;  // not equal

[bbudge, 2015/07/30 13:46:58]

Moved this to after the IS_BOOLEAN case.

       if (IS_BOOLEAN(y)) y = %$toNumber(y);
       x = %$toPrimitive(x, NO_HINT);
     }
   }
 }
 
 // ECMA-262, section 11.9.4, page 56.
 STRICT_EQUALS = function STRICT_EQUALS(x) {
   if (IS_STRING(this)) {
     if (!IS_STRING(x)) return 1;  // not equal
     return %StringEquals(this, x);
   }
 
   if (IS_NUMBER(this)) {
     if (!IS_NUMBER(x)) return 1;  // not equal
     return %NumberEquals(this, x);
   }
 
   if (IS_FLOAT32X4(this) && IS_FLOAT32X4(x))

[rossberg, 2015/07/29 14:37:55]

Same here.

[bbudge, 2015/07/30 13:46:58]

Done.

     return %Float32x4Equals(this, x);
+  if (IS_INT32X4(this) && IS_INT32X4(x))
+    return %Int32x4Equals(this, x);
+  if (IS_BOOL32X4(this) && IS_BOOL32X4(x))
+    return %Bool32x4Equals(this, x);
+  if (IS_INT16X8(this) && IS_INT16X8(x))
+    return %Int16x8Equals(this, x);
+  if (IS_BOOL16X8(this) && IS_BOOL16X8(x))
+    return %Bool16x8Equals(this, x);
+  if (IS_INT8X16(this) && IS_INT8X16(x))
+    return %Int8x16Equals(this, x);
+  if (IS_BOOL8X16(this) && IS_BOOL8X16(x))
+    return %Bool8x16Equals(this, x);
 
   // If anything else gets here, we just do simple identity check.
   // Objects (including functions), null, undefined and booleans were
   // checked in the CompareStub, so there should be nothing left.
   return %_ObjectEquals(this, x) ? 0 : 1;
 }
 
 
 // ECMA-262, section 11.8.5, page 53. The 'ncr' parameter is used as
 // the result when either (or both) the operands are NaN.
@@ skipping 583 matching lines @@
 */
 
 // ECMA-262, section 9.1, page 30. Use null/undefined for no hint,
 // (1) for number hint, and (2) for string hint.
 function ToPrimitive(x, hint) {
   // Fast case check.
   if (IS_STRING(x)) return x;
   // Normal behavior.
   if (!IS_SPEC_OBJECT(x)) return x;
   if (IS_SYMBOL_WRAPPER(x)) throw MakeTypeError(kSymbolToPrimitive);
-  if (IS_FLOAT32X4(x)) return x;
+  if (IS_SIMD_VALUE(x)) return x;
   if (hint == NO_HINT) hint = (IS_DATE(x)) ? STRING_HINT : NUMBER_HINT;
   return (hint == NUMBER_HINT) ? DefaultNumber(x) : DefaultString(x);
 }
 
 
 // ECMA-262, section 9.2, page 30
 function ToBoolean(x) {
   if (IS_BOOLEAN(x)) return x;
   if (IS_STRING(x)) return x.length != 0;
   if (x == null) return false;
   if (IS_NUMBER(x)) return !((x == 0) || NUMBER_IS_NAN(x));
   return true;
 }
 
 
 // ECMA-262, section 9.3, page 31.
 function ToNumber(x) {
   if (IS_NUMBER(x)) return x;
   if (IS_STRING(x)) {
     return %_HasCachedArrayIndex(x) ? %_GetCachedArrayIndex(x)
                                     : %StringToNumber(x);
   }
   if (IS_BOOLEAN(x)) return x ? 1 : 0;
   if (IS_UNDEFINED(x)) return NAN;
-  if (IS_SYMBOL(x)) throw MakeTypeError(kSymbolToNumber);
-  if (IS_FLOAT32X4(x)) throw MakeTypeError(kSimdToNumber);
+  // Types that can't be converted to number are caught in DefaultNumber.
   return (IS_NULL(x)) ? 0 : ToNumber(DefaultNumber(x));
 }
 
 function NonNumberToNumber(x) {
   if (IS_STRING(x)) {
     return %_HasCachedArrayIndex(x) ? %_GetCachedArrayIndex(x)
                                     : %StringToNumber(x);
   }
   if (IS_BOOLEAN(x)) return x ? 1 : 0;
   if (IS_UNDEFINED(x)) return NAN;
-  if (IS_SYMBOL(x)) throw MakeTypeError(kSymbolToNumber);
-  if (IS_FLOAT32X4(x)) throw MakeTypeError(kSimdToNumber);
+  // Types that can't be converted to number are caught in DefaultNumber.
   return (IS_NULL(x)) ? 0 : ToNumber(DefaultNumber(x));
 }
 
 
 // ECMA-262, section 9.8, page 35.
 function ToString(x) {
   if (IS_STRING(x)) return x;
   if (IS_NUMBER(x)) return %_NumberToString(x);
   if (IS_BOOLEAN(x)) return x ? 'true' : 'false';
   if (IS_UNDEFINED(x)) return 'undefined';
@@ skipping 16 matching lines @@
 }
 
 
 // ECMA-262, section 9.9, page 36.
 function ToObject(x) {
   if (IS_STRING(x)) return new GlobalString(x);
   if (IS_NUMBER(x)) return new GlobalNumber(x);
   if (IS_BOOLEAN(x)) return new GlobalBoolean(x);
   if (IS_SYMBOL(x)) return %NewSymbolWrapper(x);
   if (IS_FLOAT32X4(x)) return %NewFloat32x4Wrapper(x);
+  if (IS_INT32X4(x)) return %NewInt32x4Wrapper(x);
+  if (IS_BOOL32X4(x)) return %NewBool32x4Wrapper(x);
+  if (IS_INT16X8(x)) return %NewInt16x8Wrapper(x);
+  if (IS_BOOL16X8(x)) return %NewBool16x8Wrapper(x);
+  if (IS_INT8X16(x)) return %NewInt8x16Wrapper(x);
+  if (IS_BOOL8X16(x)) return %NewBool8x16Wrapper(x);

[bbudge, 2015/07/30 13:46:58]

Did the same thing here too, with the %IsSimdValue and a %SimdToObject
intrinsic.

   if (IS_NULL_OR_UNDEFINED(x) && !IS_UNDETECTABLE(x)) {
     throw MakeTypeError(kUndefinedOrNullToObject);
   }
   return x;
 }
 
 
 // ECMA-262, section 9.4, page 34.
 function ToInteger(x) {
   if (%_IsSmi(x)) return x;
@@ skipping 27 matching lines @@
 // ES5, section 9.12
 function SameValue(x, y) {
   if (typeof x != typeof y) return false;
   if (IS_NUMBER(x)) {
     if (NUMBER_IS_NAN(x) && NUMBER_IS_NAN(y)) return true;
     // x is +0 and y is -0 or vice versa.
     if (x === 0 && y === 0 && %_IsMinusZero(x) != %_IsMinusZero(y)) {
       return false;
     }
   }
-  if (IS_FLOAT32X4(x)) {
-    return %Float32x4SameValue(x, y);
-  }
+  if (IS_FLOAT32X4(x)) return %Float32x4SameValue(x, y);

[rossberg, 2015/07/29 14:37:55]

And here.

[bbudge, 2015/07/30 13:46:58]

Done.

+  if (IS_INT32X4(x)) return %Int32x4SameValue(x, y);
+  if (IS_BOOL32X4(x)) return %Bool32x4SameValue(x, y);
+  if (IS_INT16X8(x)) return %Int16x8SameValue(x, y);
+  if (IS_BOOL16X8(x)) return %Bool16x8SameValue(x, y);
+  if (IS_INT8X16(x)) return %Int8x16SameValue(x, y);
+  if (IS_BOOL8X16(x)) return %Bool8x16SameValue(x, y);
   return x === y;
 }
 
 
 // ES6, section 7.2.4
 function SameValueZero(x, y) {
   if (typeof x != typeof y) return false;
   if (IS_NUMBER(x)) {
     if (NUMBER_IS_NAN(x) && NUMBER_IS_NAN(y)) return true;
   }
-  if (IS_FLOAT32X4(x)) {
-    return %Float32x4SameValueZero(x, y);
-  }
+  if (IS_FLOAT32X4(x)) return %Float32x4SameValueZero(x, y);

[rossberg, 2015/07/29 14:37:56]

And here.

[bbudge, 2015/07/30 13:46:58]

Done.

+  if (IS_INT32X4(x)) return %Int32x4SameValueZero(x, y);
+  if (IS_BOOL32X4(x)) return %Bool32x4SameValueZero(x, y);
+  if (IS_INT16X8(x)) return %Int16x8SameValueZero(x, y);
+  if (IS_BOOL16X8(x)) return %Bool16x8SameValueZero(x, y);
+  if (IS_INT8X16(x)) return %Int8x16SameValueZero(x, y);
+  if (IS_BOOL8X16(x)) return %Bool8x16SameValueZero(x, y);
   return x === y;
 }
 
 
 function ConcatIterableToArray(target, iterable) {
    var index = target.length;
    for (var element of iterable) {
      %AddElement(target, index++, element);
    }
    return target;
@@ skipping 19 matching lines @@
 function IsConcatSpreadable(O) {
   if (!IS_SPEC_OBJECT(O)) return false;
   var spreadable = O[symbolIsConcatSpreadable];
   if (IS_UNDEFINED(spreadable)) return IS_ARRAY(O);
   return ToBoolean(spreadable);
 }
 
 
 // ECMA-262, section 8.6.2.6, page 28.
 function DefaultNumber(x) {
-  if (!IS_SYMBOL_WRAPPER(x) && !IS_FLOAT32X4_WRAPPER(x)) {
-    var valueOf = x.valueOf;
-    if (IS_SPEC_FUNCTION(valueOf)) {
-      var v = %_CallFunction(x, valueOf);
-      if (IsPrimitive(v)) return v;
-    }
-
-    var toString = x.toString;
-    if (IS_SPEC_FUNCTION(toString)) {
-      var s = %_CallFunction(x, toString);
-      if (IsPrimitive(s)) return s;
-    }
+  var valueOf = x.valueOf;
+  if (IS_SPEC_FUNCTION(valueOf)) {
+    var v = %_CallFunction(x, valueOf);
+    if (IS_SYMBOL(v)) throw MakeTypeError(kSymbolToNumber);
+    if (IS_SIMD_VALUE(x)) throw MakeTypeError(kSimdToNumber);
+    if (IsPrimitive(v)) return v;
+  }
+  var toString = x.toString;
+  if (IS_SPEC_FUNCTION(toString)) {
+    var s = %_CallFunction(x, toString);
+    if (IsPrimitive(s)) return s;
   }
   throw MakeTypeError(kCannotConvertToPrimitive);
 }
 
 // ECMA-262, section 8.6.2.6, page 28.
 function DefaultString(x) {
   if (!IS_SYMBOL_WRAPPER(x)) {
     var toString = x.toString;
     if (IS_SPEC_FUNCTION(toString)) {
       var s = %_CallFunction(x, toString);
@@ skipping 40 matching lines @@
 $toLength = ToLength;
 $toName = ToName;
 $toNumber = ToNumber;
 $toObject = ToObject;
 $toPositiveInteger = ToPositiveInteger;
 $toPrimitive = ToPrimitive;
 $toString = ToString;
 $toUint32 = ToUint32;
 
 })