Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1250713002: Fix pointer truncation in component_unittests. (Closed)

Created:
5 years, 5 months ago by Will Harris
Modified:
5 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix pointer truncation in component_unittests. BUG=508738 TEST=components_unittests --gtest_filter=StorageMonitorWinTest.* Committed: https://crrev.com/a56ce875c3562a113907e114f350fc55f2f7a433 Cr-Commit-Position: refs/heads/master@{#339723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M components/storage_monitor/storage_monitor_win_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M components/storage_monitor/test_storage_monitor_win.h View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/test_storage_monitor_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Will Harris
PTAL
5 years, 5 months ago (2015-07-21 17:43:27 UTC) #2
Lei Zhang
lgtm
5 years, 5 months ago (2015-07-21 19:14:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250713002/1
5 years, 5 months ago (2015-07-21 19:15:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 19:46:18 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 19:49:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a56ce875c3562a113907e114f350fc55f2f7a433
Cr-Commit-Position: refs/heads/master@{#339723}

Powered by Google App Engine
This is Rietveld 408576698