Issue 1250693003: Revert of Implements RLZTrackerDelegate on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1250693003: Revert of Implements RLZTrackerDelegate on iOS. (Closed)

Created:
5 years, 5 months ago by sdefresne

Modified:
5 years, 5 months ago

Reviewers:
droger

CC:
chromium-reviews, sdefresne+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@omnibox-events-relay

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Implements RLZTrackerDelegate on iOS. (patchset #2 id:40001 of https://codereview.chromium.org/1242373002/) Reason for revert: Landed wrong patchset. Original issue's description: > Implements RLZTrackerDelegate on iOS. > > BUG=511570 > > Committed: https://crrev.com/8ff2e5ea76f4aed908188f0368ccb12d290236a7 > Cr-Commit-Position: refs/heads/master@{#339676} TBR=droger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=511570 Committed: https://crrev.com/2979b61e15bf40459245992a817bf5f5f3c3e332 Cr-Commit-Position: refs/heads/master@{#339685}

Created: 5 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -218 lines)			Patch
M	ios/chrome/browser/pref_names.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ios/chrome/browser/pref_names.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h	View	1 chunk	+0 lines, -57 lines	0 comments	Download
D	ios/chrome/browser/rlz/rlz_tracker_delegate_impl.cc	View	1 chunk	+0 lines, -137 lines	0 comments	Download
M	ios/chrome/ios_chrome.gyp	View	2 chunks	+0 lines, -22 lines	0 comments	Download

Total messages: 4 (0 generated)

sdefresne

Created Revert of Implements RLZTrackerDelegate on iOS.

5 years, 5 months ago (2015-07-21 17:27:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250693003/1

5 years, 5 months ago (2015-07-21 17:28:56 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-21 17:33:24 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2979b61e15bf40459245992a817bf5f5f3c3e332
Cr-Commit-Position: refs/heads/master@{#339685}