Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1250683002: Reland: Move autofill tests chrome ChromeShellTest to ChromePublicTest (Closed)

Created:
5 years, 5 months ago by pkotwicz
Modified:
5 years, 5 months ago
CC:
browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Move autofill tests chrome ChromeShellTest to ChromePublicTest BUG=505040 TEST=None TBR=aurimas Committed: https://crrev.com/30fdd277283888ddd79308ae885a8ecbc3ca8fe6 Cr-Commit-Position: refs/heads/master@{#339718}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -1981 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogResult.java View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillLogger.java View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 10 chunks +10 lines, -0 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java View 1 6 chunks +16 lines, -15 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 1 5 chunks +15 lines, -7 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java View 6 chunks +17 lines, -7 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 2 chunks +14 lines, -7 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/MockAutofillDialogController.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 2 chunks +5 lines, -5 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java View 1 chunk +0 lines, -733 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 1 chunk +0 lines, -354 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java View 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/MockAutofillDialogController.java View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 1 chunk +0 lines, -277 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
pkotwicz
aurimas@ PTAL. Patch set #1 has the code as it landed in https://codereview.chromium.org/1230073003/ I removed ...
5 years, 5 months ago (2015-07-21 18:46:17 UTC) #1
aurimas (slooooooooow)
lgtm
5 years, 5 months ago (2015-07-21 18:47:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250683002/20001
5 years, 5 months ago (2015-07-21 18:53:29 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 19:35:17 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 19:49:15 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30fdd277283888ddd79308ae885a8ecbc3ca8fe6
Cr-Commit-Position: refs/heads/master@{#339718}

Powered by Google App Engine
This is Rietveld 408576698