Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 125061: Add favicons to Mac bookmark bar. (Closed)

Created:
11 years, 6 months ago by John Grabowski
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, pink (ping after 24hrs), Amanda Walker
Visibility:
Public.

Description

Add favicons to Mac bookmark bar. BUG=8381 TEST=Open bookmark bar (Cmd-B). Add some bookmarks with sites that have favicons (cnn.com). See icons in bookmark buttons. Make sure color is correct. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18340

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 16

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -7 lines) Patch
M chrome/browser/cocoa/bookmark_bar_controller.mm View 1 2 3 5 chunks +31 lines, -6 lines 0 comments Download
A chrome/browser/cocoa/cocoa_utils.h View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/cocoa_utils.mm View 1 2 3 1 chunk +99 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/cocoa_utils_unittest.mm View 1 2 3 1 chunk +83 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M skia/skia.gyp View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
John Grabowski
11 years, 6 months ago (2009-06-12 18:12:37 UTC) #1
John Grabowski
11 years, 6 months ago (2009-06-12 18:12:49 UTC) #2
TVL
lg http://codereview.chromium.org/125061/diff/10/12 File chrome/browser/cocoa/bookmark_bar_controller.mm (right): http://codereview.chromium.org/125061/diff/10/12#newcode170 Line 170: NSImage* image = SkBitmapToNSImage(favicon); do you want ...
11 years, 6 months ago (2009-06-12 19:05:14 UTC) #3
John Grabowski
http://codereview.chromium.org/125061/diff/10/12 File chrome/browser/cocoa/bookmark_bar_controller.mm (right): http://codereview.chromium.org/125061/diff/10/12#newcode170 Line 170: NSImage* image = SkBitmapToNSImage(favicon); On 2009/06/12 19:05:14, TVL ...
11 years, 6 months ago (2009-06-13 00:47:06 UTC) #4
TVL
11 years, 6 months ago (2009-06-15 00:41:22 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698