Stop using the WebView::sharedGraphicsContext3D interface.

Stop using the WebView::sharedGraphicsContext3D interface.

Instead, go directly to RenderThreadImpl and get the shared offscreen
context from there.

R=piman
BUG=177739
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186562

[danakj, 2013-03-06 00:54:53]

Hey Antoine, once you've looked over https://codereview.chromium.org/12212100/
again, can you give this a peek?

[piman, 2013-03-06 01:11:11]

lgtm

[commit-bot: I haz the power, 2013-03-06 16:01:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12506003/1

[commit-bot: I haz the power, 2013-03-06 16:01:57]

Failed to apply patch for content/renderer/render_view_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/renderer/render_view_impl.cc
  Hunk #2 succeeded at 2722 (offset 2 lines).
  Hunk #3 FAILED at 2728.
  Hunk #4 succeeded at 2742 (offset 2 lines).
  Hunk #5 succeeded at 2755 (offset 2 lines).
  1 out of 5 hunks FAILED -- saving rejects to file
content/renderer/render_view_impl.cc.rej

Patch:       content/renderer/render_view_impl.cc
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc
b/content/renderer/render_view_impl.cc
index
ef24312f356a54755764adcdb41e9cb10fa84cd7..5f82f5eeba1a5960e6e56ef940a3f27d5f5a79df
100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -216,6 +216,7 @@
 
 #if defined(OS_ANDROID)
 #include "content/common/android/device_telephony_info.h"
+#include "content/common/gpu/client/context_provider_command_buffer.h"
 #include "content/renderer/android/address_detector.h"
 #include "content/renderer/android/content_detector.h"
 #include "content/renderer/android/email_detector.h"
@@ -2719,9 +2720,6 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(
 #endif
 
 #if defined(OS_ANDROID)
-  WebGraphicsContext3D* resource_context =
-      GetWebView()->sharedGraphicsContext3D();
-
   GpuChannelHost* gpu_channel_host =
       RenderThreadImpl::current()->EstablishGpuChannelSync(
           CAUSE_FOR_GPU_LAUNCH_VIDEODECODEACCELERATOR_INITIALIZE);
@@ -2730,6 +2728,14 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(
     return NULL;
   }
 
+  scoped_refptr<cc::ContextProvider> context_provider =
+      RenderThreadImpl::current()->OffscreenContextProviderForMainThread();
+  if (!context_provider->InitializeOnMainThread() ||
+      !context_provider->BindToCurrentThread()) {
+    LOG(ERROR) << "Failed to get context3d for media player";
+    return NULL;
+  }
+
   if (cmd_line->HasSwitch(switches::kMediaPlayerInRenderProcess)) {
     if (!media_bridge_manager_.get()) {
       media_bridge_manager_.reset(
@@ -2742,7 +2748,7 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(
         media_player_manager_.get(),
         media_bridge_manager_.get(),
         new StreamTextureFactoryImpl(
-            resource_context, gpu_channel_host, routing_id_),
+            context_provider->Context3d(), gpu_channel_host, routing_id_),
         cmd_line->HasSwitch(switches::kDisableMediaHistoryLogging));
   }
   if (!media_player_proxy_) {
@@ -2755,7 +2761,7 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(
       media_player_manager_.get(),
       media_player_proxy_,
       new StreamTextureFactoryImpl(
-          resource_context, gpu_channel_host, routing_id_));
+          context_provider->Context3d(), gpu_channel_host, routing_id_));
 #endif
 
   scoped_refptr<media::AudioRendererSink> sink;

[commit-bot: I haz the power, 2013-03-06 17:28:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12506003/6001

[commit-bot: I haz the power, 2013-03-06 18:59:56]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-03-06 19:30:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12506003/6001

[commit-bot: I haz the power, 2013-03-06 19:58:26]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-06 20:48:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12506003/6001

[commit-bot: I haz the power, 2013-03-06 21:12:45]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-07 00:12:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12506003/18003

[danakj, 2013-03-07 00:45:03]

NOTRY=true so this hits canary. It already passed all the bots except mac_rel,
and the compile problem (missing header) has compiled there now.

[commit-bot: I haz the power, 2013-03-07 00:45:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12506003/18003

[commit-bot: I haz the power, 2013-03-07 01:04:47]

Change committed as 186562