Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1250573002: Revert of Roll src/third_party/skia a6ae14e:85693c1 (Closed)

Created:
5 years, 5 months ago by Matt Giuca
Modified:
5 years, 5 months ago
CC:
chromium-reviews, joshualitt, Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/skia a6ae14e:85693c1 (patchset #1 id:1 of https://codereview.chromium.org/1245793002/) Reason for revert: 942930d (included in this roll) introduced a 140 kB sizes regression in libskia.so. Please investigate and reland if this regression is necessary. (Note: I have had to revert three Skia rolls.) Original issue's description: > Roll src/third_party/skia a6ae14e:85693c1 > > Summary of changes available at: > https://chromium.googlesource.com/skia/+log/a6ae14e..85693c1 > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > TBR=joshualitt@google.com > > Commits in this roll: > 85693c1 caryclark@google.com make stroketext textblob* texteffects tileimagefilter gm portable > 942930d mtklein@chromium.org 565 support for SIMD xfermodes > 1accc4c robertphillips@google.com Fix textureDomain/bleed prevention in msaa > > Committed: https://crrev.com/56b2dde5e64a5faea6561a900cf3f27bde3d7ad9 > Cr-Commit-Position: refs/heads/master@{#339506} TBR=joshualitt@google.com,skia-deps-roller@chromium.org NOPRESUBMIT=true NOTREECHECKS=true BUG=512342 Committed: https://crrev.com/a0dffd63341d9ca3d29222f671ecde5408e6c3c7 Cr-Commit-Position: refs/heads/master@{#339633}

Patch Set 1 #

Patch Set 2 : Revert two subsequent Skia rolls. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Matt Giuca
Created Revert of Roll src/third_party/skia a6ae14e:85693c1
5 years, 5 months ago (2015-07-21 08:13:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250573002/40001
5 years, 5 months ago (2015-07-21 08:15:53 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 5 months ago (2015-07-21 09:39:03 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 09:40:01 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0dffd63341d9ca3d29222f671ecde5408e6c3c7
Cr-Commit-Position: refs/heads/master@{#339633}

Powered by Google App Engine
This is Rietveld 408576698